GitHub Actions: run clippy, check formatting #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why this change is failing… first two (on Windows and Ubuntu) were cancelled for some reason, and macOS failed, but with not much information on why:
|
|
https://github.saobby.my.eu.orgmunity/t/build-got-was-canceled-unexpectedly/16130/7 explains the first two builds are canceled because the last failed, "fail fast". The clippy task is failing. The example at https://github.com/actions-rs/clippy-check#example-workflow adds |
This reverts commit 3337334.
iceiix
added a commit
that referenced
this pull request
Jul 5, 2020
Consolidates the multitude of CI systems, replacing Azure, SourceHut, and AppVeyor with GitHub Actions, which now also runs clippy and fmt. See #352 * Add task to run clippy * Add task to check formatting * Test on 1.44.1 toolchain * Update readme: status badge and downloads on GitHub Actions * Remove strip binary task, leave it unstripped to allow debugging for now * Rename task to install dependencies * Remove Azure Pipelines * Remove sr.ht SourceHut CI * Remove AppVeyor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #352 CI/CD consolidation/enhancements