Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove viewModelScope protection #212

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Remove viewModelScope protection #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mvvm-core/src/androidMain/kotlin/dev/icerock/moko/mvvm/viewmodel/ViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import kotlinx.coroutines.cancel

@Suppress("EmptyDefaultConstructor")
actual open class ViewModel actual constructor() : ViewModel() {
protected actual val viewModelScope: CoroutineScope = createViewModelScope()
actual val viewModelScope: CoroutineScope = createViewModelScope()

public actual override fun onCleared() {
super.onCleared()
Expand Down
2 changes: 1 addition & 1 deletion mvvm-core/src/commonMain/kotlin/dev/icerock/moko/mvvm/viewmodel/ViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import kotlinx.coroutines.CoroutineScope

@Suppress("EmptyDefaultConstructor")
expect open class ViewModel() {
protected val viewModelScope: CoroutineScope
val viewModelScope: CoroutineScope

open fun onCleared()
}
2 changes: 1 addition & 1 deletion mvvm-core/src/nonAndroidMain/kotlin/dev/icerock/moko/mvvm/viewmodel/ViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import kotlinx.coroutines.cancel

@Suppress("EmptyDefaultConstructor")
actual open class ViewModel actual constructor() {
protected actual val viewModelScope: CoroutineScope = createViewModelScope()
actual val viewModelScope: CoroutineScope = createViewModelScope()

actual open fun onCleared() {
viewModelScope.cancel()
Expand Down