Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove viewModelScope protection #212

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Remove viewModelScope protection #212

merged 1 commit into from
Nov 1, 2022

Conversation

idan-fido
Copy link
Contributor

@idan-fido idan-fido commented Oct 31, 2022 •
edited
Loading

allow adding ext fun on scope

@idan-fido
Moko-MVVM viewModel
f38aa87 
- remove protected from viewModelScope
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@idan-fido idan-fido mentioned this pull request Oct 31, 2022
Closed
@Alex009 Alex009 changed the base branch from master to develop November 1, 2022 02:55
@Alex009 Alex009 added this to the 0.15.0 milestone Nov 1, 2022
@Alex009 Alex009 linked an issue Nov 1, 2022 that may be closed by this pull request
Remove viewModelScope protection #206
Closed
@Alex009 Alex009 merged commit 04afe5d into icerockdev:develop Nov 1, 2022
@idan-fido idan-fido deleted the remove_protected_viewmodel_scope branch November 1, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex009 Alex009 Alex009 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

Remove viewModelScope protection
2 participants
@idan-fido @Alex009