237 increase page size

[trey-stafford]

Looks like there are still some references to a page size of 10 in jupyter notebooks. I have not updated those, but can do so if useful!

[github-actions]

👈 Launch a binder notebook on this branch for commit 6500cad

I will automatically update this comment whenever this PR is modified

👈 Launch a binder notebook on this branch for commit a0f63a3

👈 Launch a binder notebook on this branch for commit 9cf10fa

👈 Launch a binder notebook on this branch for commit ed502b3

[trey-stafford]

Associated issue: #237

[trey-stafford]

Note that the failing test appears to be an issue on the development branch as well.

[JessicaS11]

@trey-stafford Thanks for this update from NSIDC! If you're able to update the notebooks to match the updated code, that would be awesome and much appreciated. I added in @weiji14's test fix (#241), so hopefully updating the base branch will fix the error.

[codecov-commenter]

Codecov Report

Merging #239 (a0f63a3) into development (7f38707) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           development     #239   +/-   ##
============================================
  Coverage        54.94%   54.94%           
============================================
  Files               20       20           
  Lines             1547     1547           
  Branches           321      321           
============================================
  Hits               850      850           
  Misses             639      639           
  Partials            58       58           

Impacted Files	Coverage Δ
icepyx/core/APIformatting.py	71.97% <ø> (ø)
icepyx/core/query.py	39.06% <ø> (ø)
icepyx/tests/test_visualization.py	100.00% <ø> (ø)
icepyx/tests/test_APIformatting.py	97.05% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7388316...a0f63a3. Read the comment docs.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[trey-stafford]

@trey-stafford Thanks for this update from NSIDC! If you're able to update the notebooks to match the updated code, that would be awesome and much appreciated. I added in @weiji14's test fix (#241), so hopefully updating the base branch will fix the error.

@JessicaS11 this commit corrects what I believe is the only remaining reference in the 'examples' notebooks: 9cf10fa. I've left the 'dev' notebooks untouched for now (doc/source/dev-notebooks/).

There's still a reference to using a smaller page size in examples/examples/ICESat-2_DAAC_DataAccess_Example.ipynb because it refers to synchronous requests. Note that this notebook indicates that synchronous requests are done by default, but I think this must be outdated. It looks like the request mode is async by default (https://github.com/icesat2py/icepyx/blob/development/icepyx/core/APIformatting.py#L446).

Given that the page size limit is only 100 when the request mode is synchronous, maybe we need another check somewhere that decreases the page size when a user overrides that default and uses synchronous mode?

[JessicaS11]

@trey-stafford I merged #240, so now this is out of data with the base. I also sent you an invite to the icesat2py organization so you can create a branch to submit PRs in the future and any reviewer can update from the base.