Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

By default, no email status updates to users when ordering granules #240

Merged
merged 3 commits into from
Nov 9, 2021
Merged

By default, no email status updates to users when ordering granules #240

merged 3 commits into from
Nov 9, 2021

Conversation

trey-stafford
Copy link
Contributor

resolves #238

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

Binder 👈 Launch a binder notebook on this branch for commit 42c5ccb

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 4a5b393

Binder 👈 Launch a binder notebook on this branch for commit 4a5b393

Binder 👈 Launch a binder notebook on this branch for commit f2f882e

@trey-stafford trey-stafford mentioned this pull request Nov 2, 2021
Closed
@trey-stafford
Copy link
Contributor Author

Note that the failing test appears to be an issue on the development branch as well.

@weiji14 weiji14 mentioned this pull request Nov 3, 2021
Merged
weiji14
weiji14 reviewed Nov 3, 2021
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trey-stafford! Just one suggestion on the jupyter notebook. I'll let @JessicaS11 have the final review and say on this.

P.S. I've fixed the unrelated test failure at #241.

examples/ICESat-2_DAAC_DataAccess_Example.ipynb Show resolved Hide resolved
@trey-stafford
Add email=False to example order_granules call in notebook
4a5b393 
Allows users referencing the notebook to know that `email` is an option they can
opt into.
@JessicaS11 JessicaS11 reopened this Nov 4, 2021
@JessicaS11
Copy link
Member

@trey-stafford Thanks for this update from NSIDC! If you update the base with the test fix, I'll approve the PR so the checks run and we can merge this PR.

@trey-stafford
Copy link
Contributor Author

@trey-stafford Thanks for this update from NSIDC! If you update the base with the test fix, I'll approve the PR so the checks run and we can merge this PR.

@JessicaS11 f2f882e updates this branch with development, tests should pass!

@codecov-commenter
Copy link

Codecov Report

Merging #240 (f2f882e) into development (7f38707) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #240   +/-   ##
============================================
  Coverage        54.94%   54.94%           
============================================
  Files               20       20           
  Lines             1547     1547           
  Branches           321      321           
============================================
  Hits               850      850           
  Misses             639      639           
  Partials            58       58
Impacted Files Coverage Δ
icepyx/tests/test_visualization.py 100.00% <ø> (ø)
icepyx/core/query.py 39.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7388316...f2f882e. Read the comment docs.

@JessicaS11 JessicaS11 merged commit 6ce499d into icesat2py:development Nov 9, 2021
@JessicaS11 JessicaS11 mentioned this pull request Nov 9, 2021
Merged
JessicaS11 added a commit that referenced this pull request Dec 8, 2021
@JessicaS11 @weiji14 @trey-stafford
release v0.5.0 (#250)
11569c2 
* add github action to add binder badge to PRs (#229)
* use the binder badge action directly (instead of a manual implementation of it) (#233)
See the discussion in #230 for more details on this switch.
* preliminary AWS access (#213)
* update links for travis badge (#234)
* Fix failing test_visualization_date_range check for ATL07 (#241)
* By default, no email status updates to users when ordering granules (#240)
* remove extra cell causing errors in example notebook
* Set default page size for orders to 2000 per NSIDC recommendation (#239)
* Add ICESat-2 data read-in functionality (#222)
* update examples from 2020 Hackweek tutorials
* update add and commit GitHub Action version (and UML diagrams) (#244)
* merge traffic (GitHub and PyPI) and bib updates (#245)
* Release 0.5.0 (#246)
* release v0.5.0 CI fixes (#251)
* fix Travis CI label in readme
* update earthdata login fixture for testing
* add required input to pytest fixture (#252)

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: trey-stafford <trey.stafford@colorado.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing the 'email' parameter to order requests should default to False.
4 participants
@trey-stafford @JessicaS11 @codecov-commenter @weiji14