ci: run tests with and without PAPI debug enabled #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcongiu
force-pushed
the
2023.12.01_ci
branch
from
b1420eb to
5ae5391
Compare
|
@G-Ragghianti the idea with this PR is to have PAPI tested with debug both on and off. I am not sure the way I have done things is the right though. Could you provide any feedback here? Thanks |
|
I recommend against doing two builds within the same action because you need to make sure that the builds don't interfere with each other, when one fails, it will not run the other, and when there is a failure it isn't immediately clear which build caused the failure. I recommend that we modify main.yaml to include a new axis "debug" in the actions matrix (with values "no" and "yes"). Then the existing ci.sh can be modified to reference this variable in the configure step. |
gcongiu
force-pushed
the
2023.12.01_ci
branch
from
5ae5391 to
81d65bf
Compare
gcongiu
commented
Dec 5, 2023
G-Ragghianti
approved these changes
Dec 5, 2023
gcongiu
force-pushed
the
2023.12.01_ci
branch
from
de14db6 to
307554c
Compare
gcongiu
changed the title
Tests should make sure real use cases work as expected. Some tests might not working correctly if -O0 is used as optimization level in the compiler. For example, the ROCm runtime submits a kernel of 4 waves if the tests are built using -O0, which makes the tests fail. Update the github test configuration matrix to include testing without PAPI debug.
gcongiu
force-pushed
the
2023.12.01_ci
branch
from
307554c to
bf0512c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Tests should make sure real use cases work as expected. Some tests might not working correctly if -O0 is used as optimization level in the compiler. For example, the ROCm runtime submits a kernel of 4 waves if the tests are built using -O0, which makes the tests fail.
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests