This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
Release/1.7.0 #480
Merged
Release/1.7.0 #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encoded bytes format is different Between from Rev IISS to Rev 9 * First recorded account: type is encoded as ExtType * Previously recorded account: type is encoded as primitive type * To distinguish, use is_first flag. It is only used between from Rev IISS to Rev FIX_COIN_PART_BYTES_STRUCTURE Co-authored-by: Seungmin Ryu <yakkle@gmail.com> Co-authored-by: Chiwon Cho <goldworm@icon.foundation>
- os.rename() does not work if src, dst are in different filesystem
- https://docs.python.org/3/library/shutil.html#shutil.move
* List and TypedDict are available for score parameter * Refactor IconScoreBaseMeta and IconScoreBase * Verify internal call arguments
* Version: 1.7.0rc4 * Fix a bug in convert_score_parameters() * Check if argument is a string before converting str to base object * Check for parameter types of on_install and on_update * If revision >= 9 *args or **kwargs are not allowed * Allow a score function which has @payable without @external only if revision < 9 * Union, Optional and Dict are available in SCORE * Fix a minor bug in icx_getScoreApi * Remove functions whose decorator is @payable only from function list by icx_getScoreApi * Allow extra arguments for registerPRep and setPRep if revision < 9 * Fix a bug in icx_getScoreApi and SystemScore * Fix a bug in verify_internal_call_arguments() * "None" value causes verify_internal_call_arguments() to be failed
* Version: 1.7.0rc5
* Fix a different result of _intialize_score() between 1.6.1 and 1.7.0
* IS-1157: Backward compatibility for node address division
…evision9 * response in previous format when revision is 8 * response in new format(has unstakesList) when revision is greater than 8
…n8 and revision9" This reverts commit 3ae3734.
* use linear search rather than wrong binary search to find index of new unstake slot * use revision to divide logic in normalizing stakePart method * if unstake slot if full and user add unstake, unstakeBlockHeight of last slot is max(unstakeInfo[-1][1], unstke_block_height) Co-authored-by: inwonkim <inwonkim@icon.foundation>
…on8 and revision9 (#478) * Fix getStake API to response different format when IS revision8 and revision9 * response in previous format when revision is 8 * response in new format(has unstakesList) when revision is greater than 8 * Update getStake response(rename unstakeList field to unstakes) Co-authored-by: inwonkim <inwonkim@icon.foundation>
yakkle
approved these changes
Jul 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.