Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lots of shaders to singlepass #677

Merged
merged 11 commits into from
Apr 25, 2024
Merged

Update lots of shaders to singlepass #677

merged 11 commits into from
Apr 25, 2024

Conversation

mikeskydev
Copy link
Member

@mikeskydev mikeskydev commented Apr 8, 2024

Updates the majority of our shaders to support single pass instanced rendering.

Notable exception is SE Natural Bloom which is fairly complicated, and we may be switching it soon anyways.

@mikeskydev mikeskydev added the enhancement Feature added label Apr 8, 2024
@mikeskydev mikeskydev requested a review from andybak April 8, 2024 15:26
@mikeskydev
Copy link
Member Author

Probably worth checking the CI with our supported android platforms before merging. :)

@mikeage
Copy link
Member

mikeage commented Apr 9, 2024

I expected the CI to need to recompile all of the shaders, but it doesn't seem to have needed to (at least based on the amount of time it took and lines like finished in 0.00 seconds. Local cache hits 12 (0.01s CPU time), remote cache hits 0 (0.00s CPU time), compiled 0 variants (0.00s CPU time), skipped 0 variants. I don't know anything about how shader compilation works, but did this... work?

@mikeskydev
Copy link
Member Author

A little nervous on this one, but I want to unblock @andybak's shader changes so we can just keep with multipass for now, but still merge the shaders.

@mikeskydev mikeskydev marked this pull request as ready for review April 24, 2024 21:36
@mikeskydev mikeskydev changed the title Add singlepass support on android Update lots of shaders to singlepass Apr 24, 2024
Copy link
Contributor

@andybak andybak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be also tempted to allow switching to single pass via a config setting. Maybe a separate PR? Would reduce the friction for testing in builds.

@mikeskydev
Copy link
Member Author

Ideally this should be a set and done, I just need more time to investigate! I also think it's worth temporarily delaying a switch while you've got new shaders dropping imminently.

@mikeskydev mikeskydev merged commit a48de31 into main Apr 25, 2024
42 checks passed
@mikeskydev mikeskydev deleted the feature/singlepass branch April 25, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants