-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lots of shaders to singlepass #677
Conversation
[CI BUILD]
Probably worth checking the CI with our supported android platforms before merging. :) |
I expected the CI to need to recompile all of the shaders, but it doesn't seem to have needed to (at least based on the amount of time it took and lines like |
A little nervous on this one, but I want to unblock @andybak's shader changes so we can just keep with multipass for now, but still merge the shaders. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be also tempted to allow switching to single pass via a config setting. Maybe a separate PR? Would reduce the friction for testing in builds.
Ideally this should be a set and done, I just need more time to investigate! I also think it's worth temporarily delaying a switch while you've got new shaders dropping imminently. |
Updates the majority of our shaders to support single pass instanced rendering.
Notable exception is SE Natural Bloom which is fairly complicated, and we may be switching it soon anyways.