Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview spheres for 360 images #687

Merged
merged 16 commits into from
Apr 30, 2024
Merged

Preview spheres for 360 images #687

merged 16 commits into from
Apr 30, 2024

Conversation

andybak
Copy link
Contributor

@andybak andybak commented Apr 11, 2024

image

(Now I see that screengrab it reminds me I should fix the text title wrapping while I'm here)

@andybak andybak assigned andybak and mikeage and unassigned andybak Apr 11, 2024
@andybak
Copy link
Contributor Author

andybak commented Apr 11, 2024

(This needs a fix for single-pass but I'll wait for #677 to merge before I look at that)

@mikeage mikeage removed their assignment Apr 11, 2024
@mikeskydev mikeskydev added the enhancement Feature added label Apr 24, 2024
@mikeage
Copy link
Member

mikeage commented Apr 25, 2024

677 is merged now :-)

@andybak
Copy link
Contributor Author

andybak commented Apr 29, 2024

Ironed out a final Quest weirdness. I think this is good to go.

@mikeage ?

Copy link
Member

@mikeage mikeage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd prefer to separate the panel placement into a distinct PR

@andybak
Copy link
Contributor Author

andybak commented Apr 30, 2024

Once #697 has finished doing it's thing, are you happy with a merge for this? @mikeage

@mikeage
Copy link
Member

mikeage commented Apr 30, 2024

Yes

@andybak andybak merged commit a419190 into main Apr 30, 2024
42 checks passed
@andybak andybak deleted the feature/360-preview-spheres branch April 30, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants