Update ZipFile.cs to correct the zip specification version. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the zip specification version by only checking the lower bits.
pjf
added a commit
to pjf/CKAN
that referenced
this pull request
Oct 31, 2014
Uses the patch from icsharpcode/SharpZipLib#53 . Thank you, @Novn, for writing this. Uses the build fixes from https://github.com/Arakis/SharpZipLib for Mono. Thank you, @arakis, for providing these. The branch I built from is at https://github.com/pjf/SharpZipLib/tree/ckan_gh221 Attentioning @bastianeicher who is maintaining a totally awesome SharpZipLib patches branch. @Novn's patch above fixes the bug described at http://community.sharpdevelop.net/forums/t/21758.aspx . There's a test file at https://github.com/pjf/CKAN/blob/221_ziplib/t/data/gh221.zip which shows the presence of the bug when combined with the test at https://github.com/pjf/CKAN/blob/221_ziplib/CKAN/Tests/ZipLib.cs . Closes KSP-CKAN#221. Closes KSP-CKAN/CKAN-meta#33 @malahx: I'll be releasing an updated CKAN client shortly with these fixes.
pjf
added a commit
to pjf/CKAN
that referenced
this pull request
Oct 31, 2014
Uses the patch from icsharpcode/SharpZipLib#53 . Thank you, @Novn, for writing this. Uses the build fixes from https://github.com/Arakis/SharpZipLib for Mono. Thank you, @arakis, for providing these. The branch I built from is at https://github.com/pjf/SharpZipLib/tree/ckan_gh221 Attentioning @bastianeicher who is maintaining a totally awesome SharpZipLib patches branch. @Novn's patch above fixes the bug described at http://community.sharpdevelop.net/forums/t/21758.aspx . There's a test file at https://github.com/pjf/CKAN/blob/221_ziplib/t/data/gh221.zip which shows the presence of the bug when combined with the test at https://github.com/pjf/CKAN/blob/221_ziplib/CKAN/Tests/ZipLib.cs . Closes KSP-CKAN#221. Closes KSP-CKAN/CKAN-meta#33 @malahx: I'll be releasing an updated CKAN client shortly with these fixes.
pjf
added a commit
to KSP-CKAN/CKAN-core
that referenced
this pull request
Dec 27, 2014
Uses the patch from icsharpcode/SharpZipLib#53 . Thank you, @Novn, for writing this. Uses the build fixes from https://github.com/Arakis/SharpZipLib for Mono. Thank you, @arakis, for providing these. The branch I built from is at https://github.com/pjf/SharpZipLib/tree/ckan_gh221 Attentioning @bastianeicher who is maintaining a totally awesome SharpZipLib patches branch. @Novn's patch above fixes the bug described at http://community.sharpdevelop.net/forums/t/21758.aspx . There's a test file at https://github.com/pjf/CKAN/blob/221_ziplib/t/data/gh221.zip which shows the presence of the bug when combined with the test at https://github.com/pjf/CKAN/blob/221_ziplib/CKAN/Tests/ZipLib.cs . Closes #221. Closes KSP-CKAN/CKAN-meta#33 @malahx: I'll be releasing an updated CKAN client shortly with these fixes.
pjf
added a commit
to KSP-CKAN/CKAN-netkan
that referenced
this pull request
Dec 27, 2014
Uses the patch from icsharpcode/SharpZipLib#53 . Thank you, @Novn, for writing this. Uses the build fixes from https://github.com/Arakis/SharpZipLib for Mono. Thank you, @arakis, for providing these. The branch I built from is at https://github.com/pjf/SharpZipLib/tree/ckan_gh221 Attentioning @bastianeicher who is maintaining a totally awesome SharpZipLib patches branch. @Novn's patch above fixes the bug described at http://community.sharpdevelop.net/forums/t/21758.aspx . There's a test file at https://github.com/pjf/CKAN/blob/221_ziplib/t/data/gh221.zip which shows the presence of the bug when combined with the test at https://github.com/pjf/CKAN/blob/221_ziplib/CKAN/Tests/ZipLib.cs . Closes #221. Closes KSP-CKAN/CKAN-meta#33 @malahx: I'll be releasing an updated CKAN client shortly with these fixes.
jfreilly
added a commit
that referenced
this pull request
Jan 21, 2015
Update ZipFile.cs to correct the zip specification version.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the zip specification version by only checking the lower bits; otherwise it will fail to unzip some zipped files via FastZip.ExtractZip.