Skip to content

Commit

Permalink
Updated SharpZipLib to a hand-built bugfixed copy.
Browse files Browse the repository at this point in the history
Uses the patch from icsharpcode/SharpZipLib#53 .
Thank you, @Novn, for writing this.

Uses the build fixes from https://github.com/Arakis/SharpZipLib for
Mono. Thank you, @arakis, for providing these.

The branch I built from is at
https://github.com/pjf/SharpZipLib/tree/ckan_gh221

Attentioning @bastianeicher who is maintaining a totally awesome
SharpZipLib patches branch. @Novn's patch above fixes the bug
described at http://community.sharpdevelop.net/forums/t/21758.aspx .
There's a test file at
https://github.com/pjf/CKAN/blob/221_ziplib/t/data/gh221.zip which shows
the presence of the bug when combined with the test at
https://github.com/pjf/CKAN/blob/221_ziplib/CKAN/Tests/ZipLib.cs .

Closes KSP-CKAN#221.
Closes KSP-CKAN/CKAN-meta#33

@malahx: I'll be releasing an updated CKAN client shortly with these
fixes.
  • Loading branch information
pjf committed Oct 31, 2014
1 parent 4d71d27 commit 8449b1b
Show file tree
Hide file tree
Showing 11 changed files with 9,509 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CKAN/CKAN/CKAN.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<HintPath>..\packages\Newtonsoft.Json.6.0.5\lib\net40\Newtonsoft.Json.dll</HintPath>
</Reference>
<Reference Include="ICSharpCode.SharpZipLib">
<HintPath>..\packages\SharpZipLib.0.86.0\lib\20\ICSharpCode.SharpZipLib.dll</HintPath>
<HintPath>..\packages\SharpZipLib.0.86.0-pjf-ckan_gh221\ICSharpCode.SharpZipLib.dll</HintPath>
</Reference>
<Reference Include="log4net">
<HintPath>..\packages\log4net.2.0.3\lib\net40-full\log4net.dll</HintPath>
Expand Down
2 changes: 1 addition & 1 deletion CKAN/NetKAN/NetKAN.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
</PropertyGroup>
<ItemGroup>
<Reference Include="ICSharpCode.SharpZipLib">
<HintPath>..\packages\SharpZipLib.0.86.0\lib\20\ICSharpCode.SharpZipLib.dll</HintPath>
<HintPath>..\packages\SharpZipLib.0.86.0-pjf-ckan_gh221\ICSharpCode.SharpZipLib.dll</HintPath>
</Reference>
<Reference Include="System" />
<Reference Include="Newtonsoft.Json">
Expand Down
2 changes: 1 addition & 1 deletion CKAN/Tests/Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<HintPath>..\packages\Newtonsoft.Json.6.0.5\lib\net40\Newtonsoft.Json.dll</HintPath>
</Reference>
<Reference Include="ICSharpCode.SharpZipLib">
<HintPath>..\packages\SharpZipLib.0.86.0\lib\20\ICSharpCode.SharpZipLib.dll</HintPath>
<HintPath>..\packages\SharpZipLib.0.86.0-pjf-ckan_gh221\ICSharpCode.SharpZipLib.dll</HintPath>
</Reference>
<Reference Include="System.Transactions" />
</ItemGroup>
Expand Down
Binary file not shown.
9,498 changes: 9,498 additions & 0 deletions CKAN/packages/SharpZipLib.0.86.0-pjf-ckan_gh221/ICSharpCode.SharpZipLib.xml

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions CKAN/packages/SharpZipLib.0.86.0-pjf-ckan_gh221/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
This is a patched copy of ZSharpLib which fixes the
`ZipException: Version required to extract this entry not supported (788)`
bug described [here](http://community.sharpdevelop.net/forums/t/21758.aspx).

- Get [this branch](https://github.com/pjf/SharpZipLib/tree/ckan_gh221).
- `cd SharpZipLib/src`
- `xbuild /p:Configuration=Release ICSharpCode.SharpZLib.csproj`
- Copy the build artefacts from `../bin`.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

0 comments on commit 8449b1b

Please sign in to comment.