Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics for unsupported mesh features #25278

Open
9 of 11 tasks
GiudGiud opened this issue Aug 23, 2023 · 0 comments
Open
9 of 11 tasks

Add diagnostics for unsupported mesh features #25278

GiudGiud opened this issue Aug 23, 2023 · 0 comments
Labels
C: Framework C: Meshing MeshGenerator system, mesh loading T: task An enhancement to the software.

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented Aug 23, 2023

Reason

A few features in user meshes are unsupported or undesirable. Many of them can be made with MOOSE meshgenerators even (if you combine them wrong)
We should be able to detect them as early as possible, possibly with a diagnostics object

These include:

  • non-planar faces for Ray Tracing
  • non-conformality
  • non-conformality from adaptively refined meshes
  • mixed element types in a subdomain
  • unoriented sidesets that flip normals next to subdomains
  • unoriented sidesets in general
  • sidesets that should be fully external and have an internal component
  • full mesh should be covered in sidesets (water-tight by sidesets all around)
  • too small volume elements
  • too big volume elements
  • elements overlapping

Linked to #24483

Design

A new mesh generators that loops through the mesh in a number of ways (node-loop, elem-loop, etc) to examine features that may be unsupported
It should tell you where to look for the problem

Impact

No need to peer at user meshes in Paraview as hard
Get more feedback on issues from user meshes

@GiudGiud GiudGiud added C: Framework T: task An enhancement to the software. C: Meshing MeshGenerator system, mesh loading labels Aug 23, 2023
GiudGiud added a commit to GiudGiud/moose that referenced this issue Aug 23, 2023
GiudGiud added a commit to GiudGiud/moose that referenced this issue Aug 23, 2023
GiudGiud added a commit to GiudGiud/moose that referenced this issue Aug 27, 2023
GiudGiud added a commit to GiudGiud/moose that referenced this issue Aug 28, 2023
GiudGiud added a commit to GiudGiud/moose that referenced this issue Sep 19, 2023
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
oanaoana pushed a commit to oanaoana/moose that referenced this issue Nov 7, 2023
oanaoana pushed a commit to oanaoana/moose that referenced this issue Nov 7, 2023
GiudGiud added a commit to GiudGiud/moose that referenced this issue Dec 23, 2023
lynnmunday pushed a commit to lynnmunday/moose that referenced this issue Jan 1, 2024
GiudGiud added a commit to GiudGiud/moose that referenced this issue Mar 6, 2024
schakrabortygithub pushed a commit to schakrabortygithub/moose that referenced this issue Mar 12, 2024
DanielYankura pushed a commit to DanielYankura/moose that referenced this issue Oct 7, 2024
-Loops through each element, then each face
-If face is external it needs to check if it has a sideset associate with it
-If not it needs to return an accurate warning

refs idaholab#25278
DanielYankura pushed a commit to DanielYankura/moose that referenced this issue Oct 9, 2024
-Loops through each element, then each face
-If face is external it needs to check if it has a sideset associate with it
-If not it needs to return an accurate warning

refs idaholab#25278
DanielYankura pushed a commit to DanielYankura/moose that referenced this issue Oct 9, 2024
-Works for 2D and 3D meshes
-Loops through all elements and checks each face/edge (3D/2D)
-If face/edge is external it checks if it belongs to a sideset
-If not it prints out info about the element it belongs to
-At the end it prints out how many faces/edges are missing sidesets

refs idaholab#25278
DanielYankura pushed a commit to DanielYankura/moose that referenced this issue Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework C: Meshing MeshGenerator system, mesh loading T: task An enhancement to the software.
Projects
None yet
Development

No branches or pull requests

1 participant