Talbpaul/issue mr templates #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Merged
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| The following review must be completed by an authorized member of the Change Control Board. | ||
| - [ ] 1. Review all computer code. | ||
| - [ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts). | ||
| - [ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the [wiki](https://hpcgitlab.inl.gov/idaholab/raven/wikis/Developer_Information#python-code-standard) for details. |
There was a problem hiding this comment.
We need to copy the standard to the wiki, or reference the Test Plan document instead.
There was a problem hiding this comment.
Ha, yes, this is true. Do you have a preference? I like the wiki myself. I can do that if you want.
There was a problem hiding this comment.
Sure, feel free to make the change.
|
I have reviewed the changes and had one comment. |
|
I made it a standalone page, since it contains quite a bit more information than when we first put it in "developer information". In the future as we construct the contribution guide, we can link to it from there. |
|
I have reviewed the changes. There are no code or build changes, so testing is not required. |
alfoa
pushed a commit
that referenced
this pull request
Aug 8, 2018
* serpent interface python file * output parser script * test input for raven * workDir with input file and geom file * pep8 tried * pep8 tried * Fix pep8 errors in framework/CodeInterfaces/SERPENT/SerpentInterface.py * Fix pep8 errors in framework/CodeInterfaces/SERPENT/output_parser.py * depletion composition also recorded * better path * depletion calculation * updated parser * documentation, license * more documentation and mention iso file * solves #4 * pushed to wrong repo * Revert "pushed to wrong repo" This reverts commit da500a7. * get path from script, not hardcode * percent cutoff from 0-1 * underscore to camelback script * RAVEN naming and docstring conventions * naming convention * filename change * avoid converting __ to nothing * imp_keff fix * no more underscore * test input name chnage * underscore to camelback poses too many problems * camelback interface script * import correctly * spacing for docstring * SERPENT interface documentation general * SERPENT interface manual update * test for Serpent interface test1 - input parsing * gold answer to Serpent Interface test 1 - input parsing * gitignores xml * added back model * output tests * test change to one test * Serpent test more * gold files * output files of SERPENT * reflected comments * trailing whitespace * trailing whitespace * Remove test input file * delete aux files * delete unnecessary function * interface fix * outputparser fix * delete files not read by interface * delete files not read by interface2 * delte raven-generated input files in gold * user manual fix * added examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requeset Description
What issue does this change request address?
This will close #3.
What are the significant changes in functionality due to this change request?
Adds/updates the issue/change request templates to the new repository.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.