SERPENT Interface (#604) #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* serpent interface python file * output parser script * test input for raven * workDir with input file and geom file * pep8 tried * pep8 tried * Fix pep8 errors in framework/CodeInterfaces/SERPENT/SerpentInterface.py * Fix pep8 errors in framework/CodeInterfaces/SERPENT/output_parser.py * depletion composition also recorded * better path * depletion calculation * updated parser * documentation, license * more documentation and mention iso file * solves #4 * pushed to wrong repo * Revert "pushed to wrong repo" This reverts commit da500a7. * get path from script, not hardcode * percent cutoff from 0-1 * underscore to camelback script * RAVEN naming and docstring conventions * naming convention * filename change * avoid converting __ to nothing * imp_keff fix * no more underscore * test input name chnage * underscore to camelback poses too many problems * camelback interface script * import correctly * spacing for docstring * SERPENT interface documentation general * SERPENT interface manual update * test for Serpent interface test1 - input parsing * gold answer to Serpent Interface test 1 - input parsing * gitignores xml * added back model * output tests * test change to one test * Serpent test more * gold files * output files of SERPENT * reflected comments * trailing whitespace * trailing whitespace * Remove test input file * delete aux files * delete unnecessary function * interface fix * outputparser fix * delete files not read by interface * delete files not read by interface2 * delte raven-generated input files in gold * user manual fix * added examples
aalfonsi
added
RAVENv2.2
…s://github.com/idaholab/raven into alfoa/jbae11/for_fixing_comments_not_addressed
|
@aalfonsi FYI, I have assigned it to @joshua-cogliati-inl , and he will take a look at this PR during this week. Please let me know if you have any problems. |
joshua-cogliati-inl
requested changes
Nov 12, 2021
|
@joshua-cogliati-inl @wangcj05 @mandd I fixed and addressed all the comments. This is ready to be merged |
|
Job Mingw Test on 905a978 : invalidated by @aalfonsi |
joshua-cogliati-inl
approved these changes
Dec 22, 2021
joshua-cogliati-inl
deleted the
alfoa/jbae11/for_fixing_comments_not_addressed
branch
|
Job Mingw Test on 905a978 : invalidated by @joshua-cogliati-inl never finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new interface for driving SERPENT.
In addition, in order to ease the addition of new interfaces documentation, the latex
file containing all the interfaces has been splitted in multiple files (one for each code interface)
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #1709 Closes #1734
What are the significant changes in functionality due to this change request?
Addition of the interface (coupling) between RAVEN and Serpent
In addition, the documentation of each code interface has been splitted in multiple files to help maintainability.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.