Skip to content

Commit

Permalink
Use servicetalk-grpc-protoc-all for pom.xml
Browse files Browse the repository at this point in the history
Motivation:

`build.gradle` for grpc example uses `servicetalk-grpc-protoc-all`
artifact, but `pom.xml` uses `servicetalk-grpc-protoc`. After apple#2209,
maven example does not work anymore:

servicetalk-grpc-protoc_out: ServiceTalk code generation failed:
   java.lang.NoClassDefFoundError: com/squareup/javapoet/ClassName

Modifications:

- Use `<classifier>all</classifier>` to let maven use an uber jar;

Result:

Maven build works for grpc example.

Related:

servicetalk/examples#1
  • Loading branch information
idelpivnitskiy committed May 13, 2022
1 parent 64f2716 commit cc76c68
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions servicetalk-examples/grpc/helloworld/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
<groupId>io.servicetalk</groupId>
<artifactId>servicetalk-grpc-protoc</artifactId>
<version>${servicetalk.version}</version>
<classifier>all</classifier>
<mainClass>io.servicetalk.grpc.protoc.Main</mainClass>
</protocPlugin>
</protocPlugins>
Expand Down

0 comments on commit cc76c68

Please sign in to comment.