Update dependencies, add classifier for servicetalk-grpc-protoc in pom.xml #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
May 13, 2022
Motivation: `build.gradle` for grpc example uses `servicetalk-grpc-protoc-all` artifact, but `pom.xml` uses `servicetalk-grpc-protoc`. After apple#2209, maven example does not work anymore: servicetalk-grpc-protoc_out: ServiceTalk code generation failed: java.lang.NoClassDefFoundError: com/squareup/javapoet/ClassName Modifications: - Use `<classifier>all</classifier>` to let maven use an uber jar; Result: Maven build works for grpc example. Related: servicetalk/examples#1
Scottmitch
approved these changes
May 13, 2022
Scottmitch
pushed a commit
to apple/servicetalk
that referenced
this pull request
May 13, 2022
Motivation: `build.gradle` for grpc example uses `servicetalk-grpc-protoc-all` artifact, but `pom.xml` uses `servicetalk-grpc-protoc`. After #2209, maven example does not work anymore: servicetalk-grpc-protoc_out: ServiceTalk code generation failed: java.lang.NoClassDefFoundError: com/squareup/javapoet/ClassName Modifications: - Use `<classifier>all</classifier>` to let maven use an uber jar; Result: Maven build works for grpc example. Related: servicetalk/examples#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.