Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add converting base58 to hex #6

Merged
merged 24 commits into from
Apr 10, 2024
Merged

Add converting base58 to hex #6

merged 24 commits into from
Apr 10, 2024

Conversation

sapience
Copy link
Contributor

No description provided.

@sapience sapience requested a review from pkoch March 28, 2024 15:48
README.md Outdated Show resolved Hide resolved
@@ -6,7 +6,7 @@ services:
ports:
- 50055:50055
environment:
- ETH_RPC_URL=
- ETH_RPC_URL=http://host.docker.internal:8545/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, not a great default. Unsure what to do in this specific case.

go/extension/extension.go Outdated Show resolved Hide resolved
go/extension/extension.go Outdated Show resolved Hide resolved
Copy link
Member

@pkoch pkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏓

sapience and others added 4 commits March 28, 2024 19:02
Co-authored-by: Paulo Koch <pkoch@fractal.id>
Co-authored-by: Paulo Koch <pkoch@fractal.id>
Co-authored-by: Paulo Koch <pkoch@fractal.id>
@sapience sapience requested a review from pkoch April 1, 2024 11:16
Copy link
Contributor Author

@sapience sapience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkoch Looks good.

@pkoch pkoch merged commit c612159 into main Apr 10, 2024
@pkoch pkoch deleted the feature/update_kwil branch April 10, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants