-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add converting base58 to hex #6
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
2897983
Use host machine chain
sapience 55c6aaf
Add hex_to_base58 function
sapience b7f494a
Push idos-extension image to ecr
sapience 75f7780
Disable import unexist module
sapience 89dc53a
Update mod because of security vulnerability
sapience 341ddd6
Update golang.org/x/crypto mod
sapience 1c188da
Do not deploy to staging when merge to master
sapience ec83ba7
Temporary disable slack GH actions
sapience 6228bd5
Add determine_wallet_type method
sapience dbd8459
Remove GH Actions
sapience dbee337
Clean extension code from debug
sapience d1c4aa4
Removed because no more repo the file uses
sapience 55dfb1d
Update README.md
sapience 39f029d
Update go/extension/extension.go
sapience 67dc7dd
Update go/extension/extension.go
sapience 65a9244
Align code
sapience c693072
Require the right length for NEAR implicit addresses
pkoch 0abf544
Update go/extension/extension.go
pkoch a213823
Do not fail when hex convertion failes (for eth addresses). Check len…
sapience f7b1ec5
Add IsValidPublicKey
pkoch 20f2297
Ignore built binary
pkoch d2682e2
Use a supported scalar value
pkoch 1a1c8e1
Check for payload size
pkoch b3d61c3
Add test
pkoch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
package ethereum | ||
|
||
import ( | ||
"testing" | ||
) | ||
|
||
func Test_isValidPublicKey(t *testing.T) { | ||
tests := []struct { | ||
publicKey string | ||
want bool | ||
}{ | ||
{ | ||
"", | ||
false, | ||
}, | ||
{ | ||
"some random string", | ||
false, | ||
}, | ||
{ | ||
// Address; not a public key | ||
"0x9E660ba85118b722147BBaf04ED697C95549dF03", | ||
false, | ||
}, | ||
{ | ||
"0408cf359417716c8c4dd03ab0c3b243b383599cb05c1b276b326c92a8f4b2b4acdcbdd98e9443f8bfc370b40e80f677142dab8cffd348a22fdf4b68ab61c7d78f", | ||
true, | ||
}, | ||
{ | ||
"0x0408cf359417716c8c4dd03ab0c3b243b383599cb05c1b276b326c92a8f4b2b4acdcbdd98e9443f8bfc370b40e80f677142dab8cffd348a22fdf4b68ab61c7d78f", | ||
true, | ||
}, | ||
} | ||
for _, tt := range tests { | ||
t.Run(tt.publicKey, func(t *testing.T) { | ||
if got := isValidPublicKey(tt.publicKey); got != tt.want { | ||
t.Errorf("isValidPublicKey() = %v, want %v", got, tt.want) | ||
} | ||
}) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, not a great default. Unsure what to do in this specific case.