Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement termination message for external simulation #80

Merged
merged 17 commits into from
May 17, 2022
Merged

Implement termination message for external simulation #80

merged 17 commits into from
May 17, 2022

Conversation

sebastian-peter
Copy link
Member

Resolves #35

@sebastian-peter sebastian-peter changed the title Adapting to refactored api, replacing deprecated method call Implement termination message for external simulation Jan 11, 2022
@sebastian-peter sebastian-peter force-pushed the sp/#35-ext-sim-termination-msg branch from b60dc30 to 8304878 Compare January 11, 2022 15:34
@sebastian-peter
Copy link
Member Author

sebastian-peter commented Jan 12, 2022 •
edited
Loading

Needs theses changes first: ie3-institute/simonaAPI#16 ✔️

@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@codecov
Copy link

codecov bot commented Jan 17, 2022 •
edited
Loading

Codecov Report

Merging #80 (3e3e5ee) into dev (ac43abf) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev      #80      +/-   ##
==========================================
- Coverage   79.55%   79.43%   -0.13%     
==========================================
  Files         156      156              
  Lines        5757     5767      +10     
  Branches       79       79              
==========================================
+ Hits         4580     4581       +1     
- Misses       1177     1186       +9
Impacted Files Coverage Δ
.../src/main/scala/edu/ie3/simona/sim/SimonaSim.scala 86.25% <0.00%> (-5.42%) ⬇️
...e3/simona/agent/participant/ParticipantAgent.scala 78.40% <0.00%> (-4.55%) ⬇️
...in/scala/edu/ie3/simona/agent/grid/GridAgent.scala 94.28% <0.00%> (ø)
.../main/scala/edu/ie3/simona/api/ExtSimAdapter.scala 90.32% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac43abf...3e3e5ee. Read the comment docs.

@sebastian-peter sebastian-peter self-assigned this Jan 17, 2022
@sebastian-peter sebastian-peter added the enhancement New feature or request label Jan 17, 2022
@sebastian-peter sebastian-peter marked this pull request as ready for review January 17, 2022 15:02
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
ckittl
ckittl suggested changes Jan 20, 2022
View reviewed changes
Copy link
Member

@ckittl ckittl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Changelog, no approval...

@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@ckittl
Copy link
Member

ckittl commented Mar 3, 2022

!test

@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
ckittl
ckittl previously approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@ckittl ckittl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please decide on your own, whether to take or leave the suggested changes in uml diagram.

@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
danielfeismann
danielfeismann previously approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you :)

@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sebastian-peter sebastian-peter requested a review from sensarmad May 3, 2022 07:45
@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 50 percent coverage57.14% Coverage (81.70% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

sensarmad
sensarmad approved these changes May 17, 2022
View reviewed changes
Copy link

@sensarmad sensarmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastian-peter sebastian-peter merged commit d78a2af into dev May 17, 2022
@sebastian-peter sebastian-peter deleted the sp/#35-ext-sim-termination-msg branch May 17, 2022 07:36
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sensarmad sensarmad sensarmad approved these changes

@danielfeismann danielfeismann danielfeismann approved these changes

@johanneshiry johanneshiry Awaiting requested review from johanneshiry

@ckittl ckittl Awaiting requested review from ckittl

@t-ober t-ober Awaiting requested review from t-ober

Assignees

@sebastian-peter sebastian-peter

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Implement termination message for external simulation
4 participants
@sebastian-peter @ckittl @sensarmad @danielfeismann