Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing and handling a termination message #16

Merged
merged 11 commits into from
Jan 14, 2022

Conversation

sebastian-peter
Copy link
Member

@sebastian-peter sebastian-peter commented Jan 11, 2022

Resolves #5

Plus enabling tests w/ gradle and Jenkins
Plus implementation of tests for ExtSimulation

@sonarqubegithubprchecks

This comment has been minimized.

@sebastian-peter sebastian-peter changed the title Sp/#5 ext sim termination msg Introducing and handling a termination message Jan 12, 2022
@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev@53a8ec2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev      #16   +/-   ##
======================================
  Coverage       ?   15.90%           
  Complexity     ?       10           
======================================
  Files          ?       16           
  Lines          ?      176           
  Branches       ?       19           
======================================
  Hits           ?       28           
  Misses         ?      147           
  Partials       ?        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a8ec2...1da7c8e. Read the comment docs.

Copy link
Member

@ckittl ckittl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me!

However, only point of discussion is, if we wouldn't like to see the termination as a pro-active step rather then "uh, someone else has terminated, better do that, too". In that regard: Do we need a feedback about successful termination?

@ckittl
Copy link
Member

ckittl commented Jan 14, 2022

... an please add your contributions to CHANGELOG.md

sebastian-peter and others added 2 commits January 14, 2022 10:12
Co-authored-by: Chris Kittl <44838605+ckittl@users.noreply.github.com>
@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 90 percent coverage91.67% Coverage (14.70% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:simonaAPI

View in SonarQube

@sebastian-peter
Copy link
Member Author

@ckittl introduced indication whether main simulation was successful, and a TerminationCompleted message that is sent back to main simulation when the termination process in ext sim has finished (as discussed)

@ckittl ckittl merged commit 0a6eb24 into dev Jan 14, 2022
@ckittl ckittl deleted the sp/#5-ext-sim-termination-msg branch January 14, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send terminate message to external simulation at simulation end
2 participants