-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing and handling a termination message #16
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## dev #16 +/- ##
======================================
Coverage ? 15.90%
Complexity ? 10
======================================
Files ? 16
Lines ? 176
Branches ? 19
======================================
Hits ? 28
Misses ? 147
Partials ? 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me!
However, only point of discussion is, if we wouldn't like to see the termination as a pro-active step rather then "uh, someone else has terminated, better do that, too". In that regard: Do we need a feedback about successful termination?
src/main/java/edu/ie3/simona/api/simulation/ontology/SimTerminated.java
Outdated
Show resolved
Hide resolved
... an please add your contributions to CHANGELOG.md |
Co-authored-by: Chris Kittl <44838605+ckittl@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Analysis Details0 IssuesCoverage and DuplicationsProject ID: edu.ie3:simonaAPI |
@ckittl introduced indication whether main simulation was successful, and a |
Resolves #5
Plus enabling tests w/ gradle and Jenkins
Plus implementation of tests for ExtSimulation