-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Connect Project Overview Page #76
Conversation
Visit the preview URL for this PR (updated for commit cd41bdd): https://ignite-new--pr76-jose-feat-connect-ov-l86ubru8.web.app (expires Wed, 18 May 2022 17:03:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
@JoseRFelix are these issues in the scope of this PR? (it's ok if they're not) |
Yes! |
I know we're getting fundraisers by a coordinator now, but there is an endpoint that will soon be available that will help us get the data we need (fundraiser IDs). |
Just saw this; what I'll do for now is hide the fundraiser card and in another PR add this functionality after updating the query client. I don't want to make this PR have >5K lines |
@Matthews3301 @marinhoarthur please, review. |
Can we replace |
Overall is tight. I think we should gracefully fail if either |
Only this and we're good to go imo @JoseRFelix . |
Thanks! Removed all instances of addCommasToNumber in favor of this 👍 |
Yes, there is an issue with it #93. I'll work on it |
@marinhoarthur Ready to be re-reviewed |
No description provided.