Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(campaign): add AuctionsOfCampaign query #770

Merged
merged 11 commits into from
May 9, 2022
Merged

feat(campaign): add AuctionsOfCampaign query #770

merged 11 commits into from
May 9, 2022

Conversation

giunatale
Copy link
Contributor

Closes #756

@codecov
Copy link

codecov bot commented May 6, 2022 •
edited
Loading

Codecov Report

Merging #770 (6ba6370) into develop (fcbd28e) will decrease coverage by 0.04%.
The diff coverage is 5.38%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #770      +/-   ##
===========================================
- Coverage    11.04%   10.99%   -0.05%     
===========================================
  Files          282      284       +2     
  Lines        66452    66916     +464     
===========================================
+ Hits          7337     7360      +23     
- Misses       58941    59381     +440     
- Partials       174      175       +1
Impacted Files Coverage Δ
.../campaign/client/cli/query_auctions_by_campaign.go 0.00% <0.00%> (ø)
x/campaign/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/campaign/types/query.pb.go 0.65% <0.59%> (-0.01%) ⬇️
x/campaign/keeper/grpc_auctions_by_campaign.go 100.00% <100.00%> (ø)
x/campaign/simulation/store.go 81.08% <0.00%> (-1.36%) ⬇️

@fadeev fadeev mentioned this pull request May 9, 2022
Merged
lumtis
lumtis reviewed May 9, 2022
View reviewed changes
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Otherwise the CLI works well👍

x/campaign/keeper/grpc_auctions_by_campaign.go Show resolved Hide resolved
@giunatale giunatale requested a review from lumtis May 9, 2022 15:49
@giunatale
Copy link
Contributor Author

should be good to go now

aljo242
aljo242 suggested changes May 9, 2022
View reviewed changes
proto/campaign/query.proto Outdated Show resolved Hide resolved
x/campaign/client/cli/query_auctions_by_campaign.go Outdated Show resolved Hide resolved
@giunatale giunatale requested a review from aljo242 May 9, 2022 16:52
@lumtis lumtis merged commit 464a8e0 into develop May 9, 2022
@lumtis lumtis deleted the feat/auctions-of-campaign branch May 9, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljo242 aljo242 aljo242 approved these changes

@lumtis lumtis lumtis approved these changes

@fadeev fadeev Awaiting requested review from fadeev

@ilgooz ilgooz Awaiting requested review from ilgooz

@Pantani Pantani Awaiting requested review from Pantani

@ivanovpetr ivanovpetr Awaiting requested review from ivanovpetr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a query to show a list of fundraiser IDs associated with a particular campaign ID
3 participants
@giunatale @lumtis @aljo242