Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ignite and use plugin.Flags parser #125

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Aug 5, 2024

No description provided.

@Pantani Pantani enabled auto-merge (squash) August 5, 2024 22:15
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! But CI isn't happy with latest Hermes (it is automatically installed in ignite)

@Pantani Pantani merged commit ce330d8 into main Aug 6, 2024
22 of 29 checks passed
@Pantani Pantani deleted the feat/ignite-flag branch August 6, 2024 06:41
@julienrbrt
Copy link
Member

Oh, this shouldn't have been merged. cc @Pantani we should have a follow up with the test fixes

@Pantani
Copy link
Collaborator Author

Pantani commented Aug 6, 2024

Oh, this shouldn't have been merged. cc @Pantani we should have a follow up with the test fixes

I will fix on the #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants