Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hermes): use default extensions commands instead of cobra commands #111

Merged
merged 17 commits into from
Aug 12, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Jun 26, 2024

No description provided.

@Pantani Pantani changed the title feat: use default extensions commands instead of cobra commands feat(hermes): use default extensions commands instead of cobra commands Jun 26, 2024
@Pantani
Copy link
Collaborator Author

Pantani commented Jun 26, 2024

waiting for ignite/cli#4212 merge

@Pantani
Copy link
Collaborator Author

Pantani commented Jul 8, 2024

need fix #116 first

…-cmd

# Conflicts:
#	hermes/cmd/configure.go
#	hermes/main.go
…-cmd

# Conflicts:
#	hermes/go.mod
#	hermes/main.go
@Pantani Pantani marked this pull request as ready for review July 17, 2024 20:51
@Pantani Pantani marked this pull request as draft July 18, 2024 14:21
@Pantani
Copy link
Collaborator Author

Pantani commented Jul 18, 2024

need fix #116 first

this commit creates a workaround to fix the issue now

@Pantani Pantani marked this pull request as ready for review July 18, 2024 18:56
@Pantani Pantani enabled auto-merge (squash) August 5, 2024 22:16
…-cmd

# Conflicts:
#	spaceship/go.mod
#	spaceship/go.sum
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Pantani Pantani merged commit e0194ef into main Aug 12, 2024
29 checks passed
@Pantani Pantani deleted the feat/hermes-cobra-ext-cmd branch August 12, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants