Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set default values for extension flag to dont crash ignite #4212

Merged
merged 4 commits into from
Jun 27, 2024
Merged

fix: set default values for extension flag to dont crash ignite #4212

merged 4 commits into from
Jun 27, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Jun 26, 2024

Description

Add any flag to the extension, and don't use the flag or don't set a default value to this flag crashes the extension

@Pantani Pantani self-assigned this Jun 26, 2024
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. labels Jun 26, 2024
@Pantani Pantani requested review from salmad3 and toschdev as code owners June 26, 2024 16:37
This was referenced Jun 26, 2024
Merged
Merged
Merged
@Pantani Pantani added the backport/v28.x.y Backport to v28.x.y label Jun 26, 2024
julienrbrt
julienrbrt reviewed Jun 26, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why it is needed. Could you give some context?

julienrbrt
julienrbrt approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see now, we always need to set a default. Makes sense.

@Pantani
Copy link
Collaborator Author

Pantani commented Jun 26, 2024

Oh I see now, we always need to set a default. Makes sense.

Yes, and also, if the flag is not a string and we don't use it in the command, it will break all CLI commands.

@Pantani Pantani merged commit 0aa948a into main Jun 27, 2024
44 checks passed
@Pantani Pantani deleted the fix/ext-default-values branch June 27, 2024 09:42
mergify bot pushed a commit that referenced this pull request Jun 27, 2024
@Pantani @mergify
fix: set default values for extension flag to dont crash ignite (#4212)
4c6abd7 
* set default values for extension flag to dont crash the app

* add changelog

* fix lint

(cherry picked from commit 0aa948a)
@mergify mergify bot mentioned this pull request Jun 27, 2024
Merged
julienrbrt pushed a commit that referenced this pull request Jun 28, 2024
@mergify @Pantani
fix: set default values for extension flag to dont crash ignite (#4212)…
d1a47ea 
… (#4215)

* set default values for extension flag to dont crash the app

* add changelog

* fix lint

(cherry picked from commit 0aa948a)

Co-authored-by: Danilo Pantani <danpantani@gmail.com>
@BrewTestBot BrewTestBot mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@Pantani Pantani

Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pantani @julienrbrt