Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove the ignite relayer and tools commands with all ts-relayer logic (backport #4076) #4226

Merged
merged 16 commits into from
Jul 15, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 2, 2024

needs merge ignite/apps#82 first


This is an automatic backport of pull request #4076 done by Mergify.

…ealyer logic (#4076)

* remove ts relayer

* remove unused commands

* remove ts relayer

* fix hermes relayer cmd for integration tests

* add relayer command ad default

* remove unused function

* Update changelog.md

* bump default hermes plugin version

* bump relayer into the tests

* run go mod tidy

* rollback relayer command into the integration tests

---------

Co-authored-by: Pantani <Pantani>
(cherry picked from commit 77b665f)

# Conflicts:
#	go.mod
#	go.sum
#	ignite/cmd/relayer.go
#	ignite/cmd/relayer_configure.go
#	ignite/cmd/relayer_connect.go
#	ignite/cmd/tools.go
#	ignite/pkg/nodetime/programs/ts-relayer/tsrelayer.go
#	ignite/pkg/relayer/chain.go
#	ignite/pkg/relayer/config/config.go
#	ignite/pkg/relayer/relayer.go
Copy link
Contributor Author

mergify bot commented Jul 2, 2024

Cherry-pick of 77b665f has failed:

On branch mergify/bp/release/v28.x.y/pr-4076
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit 77b665f5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	modified:   ignite/cmd/cmd.go
	modified:   ignite/cmd/plugin_default.go
	modified:   ignite/pkg/nodetime/nodetime.go
	modified:   integration/relayer/cmd_relayer_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   go.mod
	both modified:   go.sum
	deleted by them: ignite/cmd/relayer.go
	deleted by them: ignite/cmd/relayer_configure.go
	deleted by them: ignite/cmd/relayer_connect.go
	deleted by them: ignite/cmd/tools.go
	deleted by them: ignite/pkg/nodetime/programs/ts-relayer/tsrelayer.go
	deleted by them: ignite/pkg/relayer/chain.go
	deleted by them: ignite/pkg/relayer/config/config.go
	deleted by them: ignite/pkg/relayer/relayer.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@Pantani Pantani marked this pull request as draft July 2, 2024 14:26
@Pantani Pantani closed this Jul 4, 2024
@Pantani Pantani deleted the mergify/bp/release/v28.x.y/pr-4076 branch July 4, 2024 12:07
@Pantani Pantani restored the mergify/bp/release/v28.x.y/pr-4076 branch July 10, 2024 00:55
@Pantani Pantani reopened this Jul 10, 2024
…/release/v28.x.y/pr-4076

# Conflicts:
#	go.mod
#	go.sum
@Pantani Pantani marked this pull request as ready for review July 10, 2024 00:57
@Pantani Pantani self-assigned this Jul 10, 2024
@Pantani Pantani enabled auto-merge (squash) July 10, 2024 10:41
@@ -18,6 +18,8 @@ type defaultPlugin struct {
const (
PluginNetworkVersion = "v0.2.2"
PluginNetworkPath = "github.com/ignite/cli-plugin-network@" + PluginNetworkVersion
PluginRelayerVersion = "hermes/v0.2.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that version doesn't exist yet. Shall we use a commit for now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want ignite/apps#111 before tagging v0.2.4 and it needs v28.4.1 beforehand to be able to do so.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to release the version hermes/v0.2.4 based on ignite/apps#111 because we need to remove the relayer command from CLI and use it inside the Hermes app. If not the app will break

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I think I will remove the default apps now since the network is not working and the hermes needs the cycle dependency

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, so there will be like only 10 min where it won't work I guess. Makes sense.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.96%. Comparing base (232b10d) to head (691491a).
Report is 39 commits behind head on release/v28.x.y.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v28.x.y    #4226      +/-   ##
===================================================
+ Coverage            24.74%   26.96%   +2.22%     
===================================================
  Files                  297      293       -4     
  Lines                24979    24624     -355     
===================================================
+ Hits                  6182     6641     +459     
+ Misses               18230    17403     -827     
- Partials               567      580      +13     
Files Coverage Δ
ignite/cmd/cmd.go 0.00% <ø> (ø)
ignite/cmd/plugin_default.go 0.00% <ø> (-27.09%) ⬇️
ignite/pkg/nodetime/nodetime.go 0.00% <ø> (ø)

... and 5 files with indirect coverage changes

@Pantani Pantani requested a review from julienrbrt July 11, 2024 10:26
@Pantani Pantani merged commit a7aef3e into release/v28.x.y Jul 15, 2024
46 checks passed
@Pantani Pantani deleted the mergify/bp/release/v28.x.y/pr-4076 branch July 15, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants