-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove the ignite relayer
and tools
commands with all ts-relayer logic (backport #4076)
#4226
Conversation
…ealyer logic (#4076) * remove ts relayer * remove unused commands * remove ts relayer * fix hermes relayer cmd for integration tests * add relayer command ad default * remove unused function * Update changelog.md * bump default hermes plugin version * bump relayer into the tests * run go mod tidy * rollback relayer command into the integration tests --------- Co-authored-by: Pantani <Pantani> (cherry picked from commit 77b665f) # Conflicts: # go.mod # go.sum # ignite/cmd/relayer.go # ignite/cmd/relayer_configure.go # ignite/cmd/relayer_connect.go # ignite/cmd/tools.go # ignite/pkg/nodetime/programs/ts-relayer/tsrelayer.go # ignite/pkg/relayer/chain.go # ignite/pkg/relayer/config/config.go # ignite/pkg/relayer/relayer.go
Cherry-pick of 77b665f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
…/release/v28.x.y/pr-4076 # Conflicts: # go.mod # go.sum
…/release/v28.x.y/pr-4076
@@ -18,6 +18,8 @@ type defaultPlugin struct { | |||
const ( | |||
PluginNetworkVersion = "v0.2.2" | |||
PluginNetworkPath = "github.com/ignite/cli-plugin-network@" + PluginNetworkVersion | |||
PluginRelayerVersion = "hermes/v0.2.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that version doesn't exist yet. Shall we use a commit for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want ignite/apps#111 before tagging v0.2.4 and it needs v28.4.1 beforehand to be able to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to release the version hermes/v0.2.4
based on ignite/apps#111 because we need to remove the relayer command from CLI and use it inside the Hermes app. If not the app will break
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I think I will remove the default apps now since the network is not working and the hermes needs the cycle dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, so there will be like only 10 min where it won't work I guess. Makes sense.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v28.x.y #4226 +/- ##
===================================================
+ Coverage 24.74% 26.96% +2.22%
===================================================
Files 297 293 -4
Lines 24979 24624 -355
===================================================
+ Hits 6182 6641 +459
+ Misses 18230 17403 -827
- Partials 567 580 +13
|
needs merge ignite/apps#82 first
This is an automatic backport of pull request #4076 done by Mergify.