feat: scaffold consumer chain #3660

tbruyelle · 2023-09-19T13:53:41Z

Relates to #3604

This PR adds the ability to scaffold an ICS Replicated Security consumer chain. Here is the details of the changes:

Add new flag --consumer to ignite scaffold chain
Add new validation: field in config.yml, which can take sovereign (or empty, default value), consumer or provider (not implemented in this PR). I wanted to avoid kind here, but I'm not really happy with the naming, feel free to suggest better names.
Update templates for consumer chain:
- the staking, gov, distrib and mint modules are replaced with the consumer module
- a specific ante_handler is added. Note that the consumer ante handler has to be disabled during development, because it rejects any non-IBC message, which would basically make impossible any test without a provider chain and a IBC handshake properly setup. This disable is handled by a new build tag skip_ccv_msg_filter (scavenged from the Neutron source code).
Update how genesis is built, when chain config has validation: consumer, the validators list is moved from the staking module genesis to the consumer genesis, with the appropriate format.

julienrbrt · 2023-09-29T15:10:43Z

Given that ICS does not support v0.50 yet (https://github.com/cosmos/interchain-security/blob/main/go.mod#L10).
How will this work once #3659 is merged? 🤔

tbruyelle · 2023-09-29T15:25:06Z

Given that ICS does not support v0.50 yet (cosmos/interchain-security@main/go.mod#L10). How will this work once #3659 is merged? 🤔

Good catch, the first merged one will probably lock the other... So it's a question of priority. Summoning @ilgooz

ignite/config/chain/base/config.go

ignite/templates/app/files/app/ccv_msg_filter_add.go.plush

ignite/templates/app/files/app/ante_handler.go.plush

ignite/services/chain/init.go

github-actions · 2023-10-05T09:49:20Z

Visit the preview URL for this PR (updated for commit 9c12049):

https://igntservices-docs--pr3660-tbruyelle-feat-scaff-ghacxpfw.web.app

_{(expires Tue, 19 Mar 2024 19:52:37 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5}

jeronimoalbi

Good work 👍

This PR might be merged after the Cosmos SDK v0.50 update

tbruyelle · 2023-10-05T14:37:55Z

This PR might be merged after the Cosmos SDK v0.50 update

That's a little surprising since the cosmos-sdk v0.50 isn't even released (ony rc1 for now).

jeronimoalbi · 2023-10-05T14:50:20Z

That's a little surprising since the cosmos-sdk v0.50 isn't even released (ony rc1 for now).

As of right now we are aiming to first release the CLI with v0.50 support before the replicated security scaffold support in this PR. I will add an update if there is any change.

I understand the SDK release won't take long.

ignite/templates/app/files/app/consumer_devel.go.plush

codecov · 2024-03-11T10:08:39Z

Codecov Report

Attention: Patch coverage is 0% with 88 lines in your changes are missing coverage. Please review.

Project coverage is 26.06%. Comparing base (5127085) to head (9c12049).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3660      +/-   ##
==========================================
- Coverage   26.13%   26.06%   -0.08%     
==========================================
  Files         303      304       +1     
  Lines       25366    25438      +72     
==========================================
  Hits         6630     6630              
- Misses      18159    18231      +72     
  Partials      577      577

Files	Coverage Δ
ignite/services/scaffolder/module.go	`0.00% <ø> (ø)`
ignite/templates/app/options.go	`0.00% <ø> (ø)`
ignite/config/chain/base/config.go	`72.72% <0.00%> (-16.17%)`	⬇️
ignite/cmd/scaffold_chain.go	`0.00% <0.00%> (ø)`
ignite/services/chain/build.go	`0.00% <0.00%> (ø)`
ignite/services/scaffolder/init.go	`0.00% <0.00%> (ø)`
ignite/internal/plugin/consumer.go	`0.00% <0.00%> (ø)`
ignite/templates/app/app.go	`0.00% <0.00%> (ø)`
ignite/services/chain/init.go	`0.00% <0.00%> (ø)`

toschdev

ACK

* feat: add validation kind in config Disable gentx generation when validation is consumer. * Add consumer chain plush scaffolding * update config.yml when scaffold consumer chain * Add hard-coded interchain-security require * remove comment * fix bad merge go.sum * update ibc to v8 * fix changelog * chore: update interchain-security dependency Use the latest compatible with sdk50 * update ccvconsumertypes -> ccvtypes * templates: ibc-go/v7 -> ibc-go/v8 plus other dep updates * fix imports * fix imports paths * do not pass CapabilityKeeper in dep.Inject * Fix lint * fix: add missing ibcconsumer.AppModule (#3848) Co-authored-by: Pantani <Pantani> * remove ICS dep * wip exec plugin! * use plugin repo * restore templates/app/files w/o IsConsumerChain condition * create files-consumer alternate template folder * mark minimal and consumer flags as exclusive * fix wrong location for consumer_*.go files * fix error handling for IsInitialized * revert commit wip plugin exec * use plugin to read & write consumer module genesis * fix linter * backport NFT module #3924 in files-consumer * update app-consumer url * move app-consumer address to ignite org * update CL * use new plugin location * use merged version of consumer app * changelog * sync fixes * updates * fixes * changelog * feedback * fix linter * update ante handlers * import * updates --------- Co-authored-by: Ehsan-saradar <ehsan.saradar@gmail.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> (cherry picked from commit 5ed9632) # Conflicts: # ignite/cmd/scaffold_chain.go # ignite/services/scaffolder/init.go # ignite/templates/app/files/go.mod.plush

* feat: scaffold consumer chain (#3660) * feat: add validation kind in config Disable gentx generation when validation is consumer. * Add consumer chain plush scaffolding * update config.yml when scaffold consumer chain * Add hard-coded interchain-security require * remove comment * fix bad merge go.sum * update ibc to v8 * fix changelog * chore: update interchain-security dependency Use the latest compatible with sdk50 * update ccvconsumertypes -> ccvtypes * templates: ibc-go/v7 -> ibc-go/v8 plus other dep updates * fix imports * fix imports paths * do not pass CapabilityKeeper in dep.Inject * Fix lint * fix: add missing ibcconsumer.AppModule (#3848) Co-authored-by: Pantani <Pantani> * remove ICS dep * wip exec plugin! * use plugin repo * restore templates/app/files w/o IsConsumerChain condition * create files-consumer alternate template folder * mark minimal and consumer flags as exclusive * fix wrong location for consumer_*.go files * fix error handling for IsInitialized * revert commit wip plugin exec * use plugin to read & write consumer module genesis * fix linter * backport NFT module #3924 in files-consumer * update app-consumer url * move app-consumer address to ignite org * update CL * use new plugin location * use merged version of consumer app * changelog * sync fixes * updates * fixes * changelog * feedback * fix linter * update ante handlers * import * updates --------- Co-authored-by: Ehsan-saradar <ehsan.saradar@gmail.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> (cherry picked from commit 5ed9632) # Conflicts: # ignite/cmd/scaffold_chain.go # ignite/services/scaffolder/init.go # ignite/templates/app/files/go.mod.plush * fix conflicts * Update changelog.md --------- Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat: add validation kind in config Disable gentx generation when validation is consumer. * Add consumer chain plush scaffolding * update config.yml when scaffold consumer chain * Add hard-coded interchain-security require * remove comment * fix bad merge go.sum * update ibc to v8 * fix changelog * chore: update interchain-security dependency Use the latest compatible with sdk50 * update ccvconsumertypes -> ccvtypes * templates: ibc-go/v7 -> ibc-go/v8 plus other dep updates * fix imports * fix imports paths * do not pass CapabilityKeeper in dep.Inject * Fix lint * fix: add missing ibcconsumer.AppModule (#3848) Co-authored-by: Pantani <Pantani> * remove ICS dep * wip exec plugin! * use plugin repo * restore templates/app/files w/o IsConsumerChain condition * create files-consumer alternate template folder * mark minimal and consumer flags as exclusive * fix wrong location for consumer_*.go files * fix error handling for IsInitialized * revert commit wip plugin exec * use plugin to read & write consumer module genesis * fix linter * backport NFT module #3924 in files-consumer * update app-consumer url * move app-consumer address to ignite org * update CL * use new plugin location * use merged version of consumer app * changelog * sync fixes * updates * fixes * changelog * feedback * fix linter * update ante handlers * import * updates --------- Co-authored-by: Ehsan-saradar <ehsan.saradar@gmail.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>

github-actions bot assigned tbruyelle Sep 19, 2023

github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd type:services Service-related issues. type:internal component:packages and removed component:packages labels Sep 19, 2023

Ehsan-saradar self-assigned this Sep 26, 2023

github-actions bot added the component:templates label Sep 28, 2023

tbruyelle force-pushed the tbruyelle/feat/scaffold-consumer-chain branch from b7c3cc1 to 74a6048 Compare October 2, 2023 14:09

tbruyelle marked this pull request as ready for review October 2, 2023 14:09

tbruyelle requested review from ilgooz, jeronimoalbi, Pantani, julienrbrt and Ehsan-saradar as code owners October 2, 2023 14:09

jeronimoalbi mentioned this pull request Oct 3, 2023

feat: cosmos-sdk v0.50.x #3659

Merged

jeronimoalbi reviewed Oct 4, 2023

View reviewed changes

ignite/config/chain/base/config.go Show resolved Hide resolved

jeronimoalbi reviewed Oct 4, 2023

View reviewed changes

ignite/templates/app/files/app/ccv_msg_filter_add.go.plush Outdated Show resolved Hide resolved

jeronimoalbi reviewed Oct 4, 2023

View reviewed changes

ignite/templates/app/files/app/ante_handler.go.plush Outdated Show resolved Hide resolved

jeronimoalbi reviewed Oct 4, 2023

View reviewed changes

ignite/services/chain/init.go Outdated Show resolved Hide resolved

github-actions bot added the 📖 docs label Oct 5, 2023

jeronimoalbi previously approved these changes Oct 5, 2023

View reviewed changes

julienrbrt reviewed Oct 11, 2023

View reviewed changes

ignite/templates/app/files/app/consumer_devel.go.plush Outdated Show resolved Hide resolved

Merge branch 'main' into tbruyelle/feat/scaffold-consumer-chain

275380e

tbruyelle dismissed julienrbrt’s stale review via 275380e March 11, 2024 10:07

tbruyelle force-pushed the tbruyelle/feat/scaffold-consumer-chain branch from 99b790e to 275380e Compare March 11, 2024 10:07

julienrbrt previously approved these changes Mar 11, 2024

View reviewed changes

Merge branch 'main' into tbruyelle/feat/scaffold-consumer-chain

fe06403

ilgooz previously approved these changes Mar 12, 2024

View reviewed changes

This was referenced Mar 12, 2024

FIX: Prevent Overwriting ante_handler.go in App Folder #4011

Open

Rollback cosmosgenesis package #4012

Closed

update ante handlers

b31314b

julienrbrt dismissed stale reviews from ilgooz and themself via b31314b March 12, 2024 09:18

import

995627c

julienrbrt previously approved these changes Mar 12, 2024

View reviewed changes

updates

d70ad66

julienrbrt dismissed their stale review via d70ad66 March 12, 2024 09:32

toschdev previously approved these changes Mar 12, 2024

View reviewed changes

Merge branch 'main' into tbruyelle/feat/scaffold-consumer-chain

9c12049

julienrbrt dismissed toschdev’s stale review via 9c12049 March 12, 2024 19:51

julienrbrt approved these changes Mar 13, 2024

View reviewed changes

julienrbrt requested a review from toschdev March 13, 2024 09:53

julienrbrt enabled auto-merge (squash) March 13, 2024 09:54

toschdev approved these changes Mar 13, 2024

View reviewed changes

julienrbrt merged commit 5ed9632 into main Mar 13, 2024
47 of 48 checks passed

julienrbrt deleted the tbruyelle/feat/scaffold-consumer-chain branch March 13, 2024 13:51

mergify bot mentioned this pull request Mar 13, 2024

feat: scaffold consumer chain (backport #3660) #4016

Merged

julienrbrt mentioned this pull request Mar 20, 2024

chore: prepare v28.3.0 #4025

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: scaffold consumer chain #3660

feat: scaffold consumer chain #3660

tbruyelle commented Sep 19, 2023 •

edited

Loading

julienrbrt commented Sep 29, 2023 •

edited

Loading

tbruyelle commented Sep 29, 2023

github-actions bot commented Oct 5, 2023 •

edited

Loading

jeronimoalbi left a comment

tbruyelle commented Oct 5, 2023

jeronimoalbi commented Oct 5, 2023 •

edited

Loading

codecov bot commented Mar 11, 2024 •

edited

Loading

toschdev left a comment

feat: scaffold consumer chain #3660

feat: scaffold consumer chain #3660

Conversation

tbruyelle commented Sep 19, 2023 • edited Loading

julienrbrt commented Sep 29, 2023 • edited Loading

tbruyelle commented Sep 29, 2023

github-actions bot commented Oct 5, 2023 • edited Loading

jeronimoalbi left a comment

Choose a reason for hiding this comment

tbruyelle commented Oct 5, 2023

jeronimoalbi commented Oct 5, 2023 • edited Loading

codecov bot commented Mar 11, 2024 • edited Loading

Codecov Report

toschdev left a comment

Choose a reason for hiding this comment

tbruyelle commented Sep 19, 2023 •

edited

Loading

julienrbrt commented Sep 29, 2023 •

edited

Loading

github-actions bot commented Oct 5, 2023 •

edited

Loading

jeronimoalbi commented Oct 5, 2023 •

edited

Loading

codecov bot commented Mar 11, 2024 •

edited

Loading