-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: scaffold consumer chain (backport #3660) #4016
feat: scaffold consumer chain (backport #3660) #4016
Conversation
* feat: add validation kind in config Disable gentx generation when validation is consumer. * Add consumer chain plush scaffolding * update config.yml when scaffold consumer chain * Add hard-coded interchain-security require * remove comment * fix bad merge go.sum * update ibc to v8 * fix changelog * chore: update interchain-security dependency Use the latest compatible with sdk50 * update ccvconsumertypes -> ccvtypes * templates: ibc-go/v7 -> ibc-go/v8 plus other dep updates * fix imports * fix imports paths * do not pass CapabilityKeeper in dep.Inject * Fix lint * fix: add missing ibcconsumer.AppModule (#3848) Co-authored-by: Pantani <Pantani> * remove ICS dep * wip exec plugin! * use plugin repo * restore templates/app/files w/o IsConsumerChain condition * create files-consumer alternate template folder * mark minimal and consumer flags as exclusive * fix wrong location for consumer_*.go files * fix error handling for IsInitialized * revert commit wip plugin exec * use plugin to read & write consumer module genesis * fix linter * backport NFT module #3924 in files-consumer * update app-consumer url * move app-consumer address to ignite org * update CL * use new plugin location * use merged version of consumer app * changelog * sync fixes * updates * fixes * changelog * feedback * fix linter * update ante handlers * import * updates --------- Co-authored-by: Ehsan-saradar <ehsan.saradar@gmail.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> (cherry picked from commit 5ed9632) # Conflicts: # ignite/cmd/scaffold_chain.go # ignite/services/scaffolder/init.go # ignite/templates/app/files/go.mod.plush
Cherry-pick of 5ed9632 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Visit the preview URL for this PR (updated for commit 75f5bfc): https://igntservices-docs--pr4016-mergify-bp-release-v-0sj48wdr.web.app (expires Thu, 21 Mar 2024 16:32:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v28.x.y #4016 +/- ##
===================================================
- Coverage 24.81% 24.74% -0.07%
===================================================
Files 296 297 +1
Lines 24909 24977 +68
===================================================
Hits 6180 6180
- Misses 18161 18229 +68
Partials 568 568
|
Relates to #3604
This PR adds the ability to scaffold an ICS Replicated Security consumer chain. Here is the details of the changes:
--consumer
toignite scaffold chain
validation:
field inconfig.yml
, which can takesovereign
(or empty, default value),consumer
orprovider
(not implemented in this PR). I wanted to avoidkind
here, but I'm not really happy with the naming, feel free to suggest better names.staking
,gov
,distrib
andmint
modules are replaced with theconsumer
moduleskip_ccv_msg_filter
(scavenged from the Neutron source code).validation: consumer
, the validators list is moved from thestaking
module genesis to theconsumer
genesis, with the appropriate format.This is an automatic backport of pull request #3660 done by [Mergify](https://mergify.com).