fix: use getter to read first config validator #3969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getter checks that there is at least a validator configured and otherwise returns a proper error
jeronimoalbi
requested review from
ilgooz,
Pantani,
julienrbrt and
Ehsan-saradar
as code owners
github-actions
bot
added
component:ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3969 +/- ##
=======================================
Coverage 24.79% 24.79%
=======================================
Files 296 296
Lines 24907 24913 +6
=======================================
+ Hits 6176 6178 +2
- Misses 18164 18169 +5
+ Partials 567 566 -1
|
|
@Mergifyio backport release/v28.x.y |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
* fix: use getter to read first config validator Getter checks that there is at least a validator configured and otherwise returns a proper error * chore: update changelog (cherry picked from commit 55ad250)
julienrbrt
added a commit
that referenced
this pull request
Apr 4, 2024
* fix: use getter to read first config validator (#3969) * fix: use getter to read first config validator Getter checks that there is at least a validator configured and otherwise returns a proper error * chore: update changelog (cherry picked from commit 55ad250) * updates --------- Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
Merged
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
* fix: use getter to read first config validator Getter checks that there is at least a validator configured and otherwise returns a proper error * chore: update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getter checks that there is at least a validator configured or otherwise returns a proper error.
Fixes #3968