Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use getter to read first config validator (backport #3969) #4069

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 4, 2024

Getter checks that there is at least a validator configured or otherwise returns a proper error.

Fixes #3968


This is an automatic backport of pull request #3969 done by Mergify.

* fix: use getter to read first config validator

Getter checks that there is at least a validator configured and
otherwise returns a proper error

* chore: update changelog

(cherry picked from commit 55ad250)
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 24.73%. Comparing base (5b85200) to head (8c90b8c).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v28.x.y    #4069      +/-   ##
===================================================
- Coverage            24.74%   24.73%   -0.01%     
===================================================
  Files                  297      297              
  Lines                24977    24983       +6     
===================================================
  Hits                  6180     6180              
- Misses               18229    18235       +6     
  Partials               568      568              
Files Coverage Δ
ignite/cmd/chain_debug.go 0.00% <0.00%> (ø)
ignite/services/chain/chain.go 8.33% <0.00%> (-0.09%) ⬇️

@julienrbrt julienrbrt merged commit a1cb023 into release/v28.x.y Apr 4, 2024
42 of 44 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-3969 branch April 4, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants