feat: skip Ignite app load for some commands #3972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:ci
|
There is no need to check that apps are not registering commands for Ignite commands that doesn't allow apps because those commands are runnable ( |
jeronimoalbi
requested review from
ilgooz,
salmad3,
toschdev,
Pantani,
julienrbrt and
Ehsan-saradar
as code owners
Pantani
previously approved these changes
Feb 15, 2024
All of the runnable commands that should not load Ignite apps are level one commands (`ignite` command children), so a simple check is enough.
Pantani
approved these changes
Feb 16, 2024
salmad3
approved these changes
Feb 16, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
* feat: skil Ignite app load for some commands * chore: update changelog * ci: fix linting issue * fix: change app load check to validate level one commands only All of the runnable commands that should not load Ignite apps are level one commands (`ignite` command children), so a simple check is enough. * chore: fix comment --------- Co-authored-by: Danilo Pantani <danpantani@gmail.com> (cherry picked from commit 82ec261)
julienrbrt
pushed a commit
that referenced
this pull request
Feb 16, 2024
Merged
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
* feat: skil Ignite app load for some commands * chore: update changelog * ci: fix linting issue * fix: change app load check to validate level one commands only All of the runnable commands that should not load Ignite apps are level one commands (`ignite` command children), so a simple check is enough. * chore: fix comment --------- Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3929