feat: skip Ignite app load for some commands (backport #3972) #3975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* feat: skil Ignite app load for some commands * chore: update changelog * ci: fix linting issue * fix: change app load check to validate level one commands only All of the runnable commands that should not load Ignite apps are level one commands (`ignite` command children), so a simple check is enough. * chore: fix comment --------- Co-authored-by: Danilo Pantani <danpantani@gmail.com> (cherry picked from commit 82ec261)
mergify
bot
requested review from
ilgooz,
salmad3,
toschdev,
jeronimoalbi,
Pantani and
julienrbrt
as code owners
github-actions
bot
added
component:ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/v28.x.y #3975 +/- ##
===================================================
- Coverage 24.80% 24.80% -0.01%
===================================================
Files 296 296
Lines 24904 24906 +2
===================================================
Hits 6178 6178
- Misses 18160 18162 +2
Partials 566 566
|
Pantani
approved these changes
Feb 16, 2024
julienrbrt
reviewed
Feb 16, 2024
julienrbrt
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3972 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com