feat: add custom flag parser for extensions #4269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
requested review from
ilgooz,
jeronimoalbi and
julienrbrt
as code owners
github-actions
bot
added
component:ci
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
* add custom flag parser * add changelog (cherry picked from commit 8ff971f) # Conflicts: # ignite/cmd/plugin_test.go
Pantani
added a commit
that referenced
this pull request
Jul 25, 2024
* feat: add custom flag parser for extensions (#4269) * add custom flag parser * add changelog (cherry picked from commit 8ff971f) # Conflicts: # ignite/cmd/plugin_test.go * resolve conflicts * fix changelog --------- Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close ignite/apps#116
Description
This PR creates a simple flag parser, so we don't need to depend on another library to parse a few objects. It also solves the issue of missing default values in the flags.