Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom flag parser for extensions (backport #4269) #4271

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 19, 2024

close ignite/apps#116

Description

This PR creates a simple flag parser, so we don't need to depend on another library to parse a few objects. It also solves the issue of missing default values in the flags.


This is an automatic backport of pull request #4269 done by Mergify.

* add custom flag parser

* add changelog

(cherry picked from commit 8ff971f)

# Conflicts:
#	ignite/cmd/plugin_test.go
Copy link
Contributor Author

mergify bot commented Jul 19, 2024

Cherry-pick of 8ff971f has failed:

On branch mergify/bp/release/v28.x.y/pr-4269
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit 8ff971fc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	new file:   ignite/services/plugin/flag.go
	new file:   ignite/services/plugin/flag_test.go
	modified:   integration/plugin/testdata/example-plugin/main.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ignite/cmd/plugin_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd type:services Service-related issues. labels Jul 19, 2024
@Pantani Pantani merged commit 06bfcd9 into release/v28.x.y Jul 25, 2024
44 checks passed
@Pantani Pantani deleted the mergify/bp/release/v28.x.y/pr-4269 branch July 25, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs conflicts type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants