Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps for Dome: use msgs6 #149

Merged
merged 5 commits into from
Jul 21, 2020
Merged

Update deps for Dome: use msgs6 #149

merged 5 commits into from
Jul 21, 2020

Conversation

j-rivero
Copy link
Contributor

As part of the works of gazebo-tooling/gazebodistro#5 bump the use of msgs to major version 6

@j-rivero j-rivero requested a review from caguero as a code owner July 10, 2020 12:06
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jul 10, 2020
@j-rivero j-rivero force-pushed the update_dome_versions branch from 751754c to 79e93f0 Compare July 10, 2020 12:09
This was referenced Jul 10, 2020
Merged
Merged
chapulina
chapulina approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to merge CI first. Also, be sure to sign all commits 😉

caguero
caguero requested changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about updating .gitbug/workflows/ci-bionic.yaml? Otherwise I think CI will break.

@caguero
Copy link
Collaborator

caguero commented Jul 13, 2020

Should we also remove bitbucket-pipelines?

@j-rivero j-rivero force-pushed the update_dome_versions branch from e31f0d3 to 7ac677c Compare July 13, 2020 16:11
@j-rivero
Copy link
Contributor Author

How about updating .gitbug/workflows/ci-bionic.yaml? Otherwise I think CI will break.

I would like to avoid the duplication of build-from-source dependencies (we already do that in release-tools) since it adds a good amount of overhead to manage changes in all the repositories, at least until we have a common solution in place. We can discuss this within the project, it is a structural problem of having CI code in many different places.

Should we also remove bitbucket-pipelines?

We are still using it to determine the platform to build branches. That functionality needs to be migrated first.

@chapulina chapulina mentioned this pull request Jul 16, 2020
Merged
@chapulina
Copy link
Contributor

chapulina commented Jul 16, 2020 •
edited
Loading

Pending CI fixes:

j-rivero added 5 commits July 17, 2020 15:11
@j-rivero
Update deps for Dome: use msgs6
bf159c5 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Add msgs6 to docker and configure.bat
2ae1812 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Update changelog
5cc950d 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Test gzdev branch in ci-bionic
5aa2c5e 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
use master to get msgs6
872d8ac 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero force-pushed the update_dome_versions branch from 4226943 to 872d8ac Compare July 17, 2020 13:11
@j-rivero
Copy link
Contributor Author

Github actions are reporting green although it is a false positive, related to gazebo-tooling/action-gz-ci#11.

In order to make it work properly with nightlies we need gazebo-tooling/action-gz-ci#12 and change this repo to use gzdev_project_name.

@chapulina
Copy link
Contributor

@osrf-jenkins run tests please

chapulina
chapulina approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Jenkins CI is passing. OSX has 1 test failure and OSX / Windows have warnings. I think we can fix actions later, because all branches will need fixes.

What do you think, @caguero , can we merge so we can move on with the downstream libs?

@caguero
Copy link
Collaborator

caguero commented Jul 21, 2020

All Jenkins CI is passing. OSX has 1 test failure and OSX / Windows have warnings. I think we can fix actions later, because all branches will need fixes.

What do you think, @caguero , can we merge so we can move on with the downstream libs?

Looks good!

@chapulina chapulina merged commit d72d63e into master Jul 21, 2020
@chapulina chapulina deleted the update_dome_versions branch July 21, 2020 19:41
@scpeters scpeters mentioned this pull request Nov 4, 2021
Closed
35 tasks
@chapulina chapulina mentioned this pull request Nov 12, 2021
Closed
21 tasks
This was referenced Nov 19, 2021
Closed
Closed
@methylDragon methylDragon mentioned this pull request Apr 6, 2022
Closed
43 tasks
@iche033 iche033 mentioned this pull request Nov 14, 2022
Closed
35 tasks
@iche033 iche033 mentioned this pull request Feb 16, 2023
Closed
12 tasks
@azeey azeey mentioned this pull request Jul 28, 2023
Closed
12 tasks
@azeey azeey mentioned this pull request Oct 6, 2023
Closed
83 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@caguero caguero caguero approved these changes

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-rivero @caguero @chapulina