Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: document() with latest roxygen2 #1113

Closed
wants to merge 4 commits into from
Closed

refactor: document() with latest roxygen2 #1113

wants to merge 4 commits into from

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Jan 15, 2024

Many changes due to @krlmlr's r-lib/roxygen2#1563
Merging this will allow for a cleaner diff next time we have to use document() 😁

@maelle maelle requested a review from krlmlr January 15, 2024 12:52
Copy link
Contributor

aviator-app bot commented Jan 15, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.


See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@maelle maelle removed the request for review from krlmlr January 16, 2024 08:18
@aviator-app aviator-app bot added the blocked label Jan 16, 2024
Copy link
Contributor

aviator-app bot commented Jan 16, 2024

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Remove the blocked label to re-queue.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).

@maelle maelle removed the blocked label Jan 16, 2024
@krlmlr krlmlr marked this pull request as draft January 16, 2024 10:23
@krlmlr
Copy link
Contributor

krlmlr commented Jan 16, 2024

Can you please use the GitHub version of roxygen2? It's better regarding the order of see-also-s.

@aviator-app aviator-app bot added the blocked label Jan 16, 2024
Copy link
Contributor

aviator-app bot commented Jan 16, 2024

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Remove the blocked label to re-queue.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).

@aviator-app aviator-app bot removed the mergequeue label Jan 16, 2024
Copy link
Contributor

aviator-app bot commented Jan 16, 2024

This pull request can't be queued because it's currently a draft.

@maelle maelle marked this pull request as ready for review January 16, 2024 10:53
@maelle maelle added mergequeue and removed blocked labels Jan 16, 2024
@maelle maelle closed this Jan 16, 2024
@maelle
Copy link
Contributor Author

maelle commented Jan 16, 2024

nothing changed in the end!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants