More careful ordering for @family tag
#1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
force-pushed
the
b-family-order
branch
3 times, most recently
from
fac5576
to
2acfe95
Compare
krlmlr
force-pushed
the
b-family-order
branch
3 times, most recently
from
95a6610
to
afbabca
Compare
hadley
approved these changes
Jan 2, 2024
tests/testthat/test-rd-family.R
Outdated
| @@ -123,3 +123,29 @@ test_that("custom family prefixes can be set", { | |||
|
|
|||
| expect_match(out$get_value("seealso"), "^Custom prefix:") | |||
| }) | |||
|
|
|||
| test_that("careful ordering", { | |||
| # Can't use foo1 because it's used as class in another test | |||
There was a problem hiding this comment.
Is it an S4 class? It might need a on.exit(removeClass("foo1")) call.
There was a problem hiding this comment.
No, unfortunately, #1564 does not change the behavior here.
There was a problem hiding this comment.
Happy to adapt if #1566 or a better version gets in.
|
Thanks, good to go from my end. |
|
Done, finally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for DBI:
dbSendQuery()vs.dbSendQueryArrow().Test-first, the second commit afbabca shows the effect. Happy to revisit the implementation and/or switch the other tests to snapshots.
I suspect that the new
order_c()should be used almost everywhere where we now haveorder().