Exception for the intersectionWith method #64
Conversation
Richiedu38
force-pushed
the
feature/shapes-intersection
branch
from
66a1ca1
to
05face5
Compare
|
|
||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
To be consistent with the other intersection algos, let's call intersectionToPack.setToNaN() when it's not intersecting.
| Point3DBasics secondIntersectionToPack) | ||
|
|
||
| { | ||
|
|
There was a problem hiding this comment.
let's add here:
if (firstIntersectionToPack == null) firstIntersectionToPack = new Point3D();
if (secondIntersectionToPack == null) secondIntersectionToPack = new Point3D();
|
|
||
| //For each face, we check the possibility of intersection with the line | ||
| for (int i=0; i< getNumberOfFaces(); i++) { | ||
| //If there isn't already a intersection found |
There was a problem hiding this comment.
The conditions in this loop aren't working, also you've got a bug due to a bad copy-paste. I'll let you figure out how to fix this loop.
| break; | ||
| } | ||
|
|
||
| return numberOfIntersections; |
There was a problem hiding this comment.
Before returning, we need to check the ordering of the 2 intersections to be consistent with the other intersection algorithms
| if (numberOfIntersections == 1) | ||
| return numberOfIntersections; | ||
|
|
||
| if (numberOfIntersections == 2 && EuclidCoreTools.epsilonEquals(firstIntersectionToPack, secondIntersectionToPack, 1.0e-7)) |
There was a problem hiding this comment.
Here we already know that numberOfIntersections == 2, there is no need to test for it in that if condition.
Also, the secondIntersectionToPack should be set to NaN
| // Swap intersections | ||
| Point3DBasics temp = firstIntersectionToPack; | ||
| firstIntersectionToPack = secondIntersectionToPack; | ||
| secondIntersectionToPack = temp; |
There was a problem hiding this comment.
This won't work, you're changing method's internal references, from the caller's perspective.
Your test should fail on this, if not, you want to update it to test the ordering the intersections.
The only solution here is to update the content of the 2 objects, so:
double tempX = firstInstersectionToPack.getX();
double tempY = firstInstersectionToPack.getY();
double tempZ = firstInstersectionToPack.getZ();
firstInstersectionToPack.set(secondInstersectionToPack);
secondIntersectionToPack.set(tempX, tempY, tempZ);
| assertEquals(2, convexPolytope3D.intersectionWith(pointOnFace, direction, null, actualSecondInstersection)); | ||
| actualFirstInstersection.setToZero(); | ||
| actualSecondInstersection.setToZero(); | ||
| assertEquals(2, convexPolytope3D.intersectionWith(pointOnFace, direction, actualFirstInstersection, actualSecondInstersection)); |
There was a problem hiding this comment.
Ok so your test here only asserts that the method returns the expected number of intersections, it doesn't assert that the computed intersections are correct nor in the right order.
| double y = alpha * A.getY() + beta * B.getY() + gamma * C.getY(); | ||
| double z = alpha * A.getZ() + beta * B.getZ() + gamma * C.getZ(); | ||
|
|
||
| Point3D pointOnFace = new Point3D(x, y, z); |
There was a problem hiding this comment.
I'd suggest wrapping the above code for generating a random point in a face into a static method here.
Eclipse can help you do that, select the code, then right click, refactor > extract method
| assertEquals(0, convexPolytope3D.intersectionWith(pointOutside, lineDirection, null, actualSecondInstersection)); | ||
| actualFirstInstersection.setToZero(); | ||
| actualSecondInstersection.setToZero(); | ||
| assertEquals(0, convexPolytope3D.intersectionWith(pointOutside, lineDirection, actualFirstInstersection, actualSecondInstersection)); |
There was a problem hiding this comment.
I think we can find more constructions to cover more scenarios with no intersection
| assertEquals(2, convexPolytope3D.intersectionWith(pointInside, lineDirection, null, actualSecondInstersection)); | ||
| actualFirstInstersection.setToZero(); | ||
| actualSecondInstersection.setToZero(); | ||
| assertEquals(2, convexPolytope3D.intersectionWith(pointInside, lineDirection, actualFirstInstersection, actualSecondInstersection)); |
There was a problem hiding this comment.
Here you've got the intersections that are known, you should easily be able to check the ones that are computed
| assertEquals(2, convexPolytope3D.intersectionWith(pointInside, lineDirection, actualFirstInstersection, actualSecondInstersection)); | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Missing test for 1 intersection: through a vertex and through an edge.
Missing annoying edge-case: the line is in-plane of a face, there should be 2 intersections still
src/geometry/java/us/ihmc/euclid/geometry/tools/EuclidGeometryTools.java
Outdated
Show resolved
Hide resolved
To avoid error messages during compilation due to the absence of the intersectionWith method for some shapes, I added an exception returning 'Intersection line capsule isn't supported'.