Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bamboo specific stuff #79

Merged
merged 8 commits into from
Sep 12, 2024
Merged

Remove bamboo specific stuff #79

merged 8 commits into from
Sep 12, 2024

Conversation

ds58
Copy link
Contributor

@ds58 ds58 commented Aug 15, 2024 •
edited
Loading

Changes:

  • Remove any implementation of the legacy "Nexus REST API" for integration number
  • Removed the tests for the REST API
  • Remove concept of integration number
  • Remove JCenter
  • Removed commented code regarding legacy source sets
  • Removed concept of "branch builds" and "bamboo builds"
  • Removed most of the composite build snapshot dependency resolution, as it was just for bamboo
  • Remove html library (unirest-java)
  • Rename nexusUsername, nexusPassword to ihmcNexusUsername, ihmcNexusPassword (only in code, the properties stay the same)
  • Remove the ability to configure the nexus URL; it is ihmc specific, ihmcNexusUrl
  • Removed extra whitespace in IHMCBuildExtension.kt, minor formatting

@ds58 ds58 requested review from calvertdw and removed request for calvertdw August 15, 2024 19:19
@ds58
Copy link
Contributor Author

ds58 commented Aug 15, 2024

@calvertdw Sorry, didn't mean to add you yet

@ds58 ds58 requested a review from calvertdw August 16, 2024 16:24
@ds58 ds58 changed the title [WIP] Remove bamboo specific stuff Remove bamboo specific stuff Aug 16, 2024
@calvertdw calvertdw force-pushed the remove-bamboo branch 2 times, most recently from be30c25 to 37bde13 Compare September 6, 2024 15:48
calvertdw
calvertdw reviewed Sep 6, 2024
View reviewed changes
src/main/kotlin/us/ihmc/build/IHMCBuildExtension.kt
@@ -49,98 +48,35 @@ open class IHMCBuildExtension(val project: Project)
private val snapshotModeProperty: Boolean
private val publishUrlProperty: String
private val ciDatabaseUrlProperty: String
private val nexusUrlProperty = IHMCBuildTools.nexusUrlCompatibility(project.extra)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this, and a little worried

calvertdw
calvertdw reviewed Sep 6, 2024
View reviewed changes
src/main/kotlin/us/ihmc/build/IHMCBuildExtension.kt

private var ihmcNexusUrl = "https://nexus.ihmc.us"
private var ihmcNexusUsername: String
private var ihmcNexusPassword: String
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the rename with the ihmc prefix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's specifically ihmc's Nexus instance

@calvertdw
Copy link
Member

I put the remove JCenter on develop, since that one is a known isolated good thing

@calvertdw calvertdw closed this Sep 6, 2024
@ds58 ds58 reopened this Sep 6, 2024
@ds58 ds58 merged commit 14667fb into develop Sep 12, 2024
2 checks passed
@ds58 ds58 deleted the remove-bamboo branch September 18, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvertdw calvertdw calvertdw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ds58 @calvertdw