Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jspInserts not loading in proper location #360

Closed
jason-ellis opened this issue Sep 28, 2017 · 1 comment · Fixed by #405
Closed

jspInserts not loading in proper location #360

jason-ellis opened this issue Sep 28, 2017 · 1 comment · Fixed by #405

Comments

@jason-ellis
Copy link
Contributor

jason-ellis commented Sep 28, 2017 •
edited
Loading

I'm not sure how prevalent this issue is, but it is noticeable when archiving this page: http://glasstire.com

Normally, /WEB-INF/replay/Disclaimer.jsp is printed immediately following the opening <body> tag. In the page above, it's printed inside of a <noscript> tag that appears in the head in the live site.

This prevents the relevant code from executing to add the disclaimer to the top of the page.
@ldko
Copy link
Member

ldko commented Jul 31, 2019

#319 seems relevant

ldko added a commit that referenced this issue Aug 6, 2019
@ldko
Avoid inserting toolbar in NOSCRIPT tag.
31826be 
This is to fix #360 by storing that HEAD has been inserted
when there was no `headInsertJsp`.
ldko added a commit that referenced this issue Aug 7, 2019
@ldko
Avoid inserting toolbar in NOSCRIPT tag.
c863f32 
This is to fix #360 by storing that HEAD has been inserted
even when there was no `headInsertJsp`.
@ldko ldko mentioned this issue Aug 7, 2019
Merged
ldko added a commit that referenced this issue Aug 7, 2019
@ldko
Update release notes for #360
ea01f3d
@ldko ldko closed this as completed in #405 Aug 13, 2019
ldko added a commit that referenced this issue Aug 13, 2019
@ldko
Avoid inserting toolbar in NOSCRIPT tag.
4c0ccaa 
This is to fix #360 by storing that HEAD has been inserted
when there was no `headInsertJsp`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid inserting toolbar in NOSCRIPT tag. iipc/openwayback
2 participants
@jason-ellis @ldko