Allow any elements to happen inside NOSCRIPT without triggering bodyInsert. #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsert.
Squashed commit of the following:
commit cd186cd43bd939b7323470c888b025b610d5d4c8
Author: Kenji Nagahashi <kenji@archive.org>
Date: Fri Feb 26 13:21:37 2016 -0800
bare minimum change to allow NOSCRIPT inside HEAD to have any child elements without triggering bodyInsert.
commit 02c2d9f33bdee484764348e0b5ede0323272d0f1
Author: Kenji Nagahashi <kenji@archive.org>
Date: Tue Feb 2 15:00:54 2016 -0800
Add tests for ARI-4691: allow non-head elements inside NOSCRIPT (tests fail)
runderwood
approved these changes
Mar 2, 2017
| @@ -158,6 +164,10 @@ public void handleNode(ParseContext pContext, Node node) throws IOException { | |||
| if (tagNode.isEndTag()) { | |||
| if (tagNode.getTagName().equals("HEAD")) { | |||
| context.putData(FERRET_IN_HEAD, null); | |||
| // turn off NOSCIPT state as well. It's inside HEAD only. | |||
There was a problem hiding this comment.
Tiny typo in this comment.
| // NOSCRIPT under HEAD may contain elements that usually happen | ||
| // inside BODY. As long as they are inside NOSCRIPT, we let them go | ||
| // without inserting bodyInsert. Note this is NOSCRIPT under HEAD | ||
| // only. If <NOSCRIPT> happens before <HEAD>, non-HEAD elements in |
There was a problem hiding this comment.
Do you see NOSCRIPT tags outside of the HEAD in practice? Mostly curious. Not sure I've come across that myself.
If it does happen in practice, should we make another issue to handle that case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #306. We encountered cases where NOSCRIPT occurs in HEAD and it contains elements as its children that don't usually happen in HEAD directly - IMG, DIV and IFRAME. Even with #307, these child elements trigger bodyInsert and break the layout.
This patch allows arbitrary elements to occur inside NOSCRIPT without triggering bodyInsert.
Original issue item: internetarchive#119