Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downstreamed changes from ember-codemod-v1-to-v2 #23

Merged
merged 12 commits into from
May 3, 2023
Merged

Conversation

@ijlee2 ijlee2 added enhance: code Issue asks for new feature or refactor enhance: dependency Issue asks for a new or updated dependency labels May 3, 2023
@@ -31,7 +31,7 @@
"test": "mt tests --quiet"
},
"dependencies": {
"glob": "^10.2.2",
"glob": "~10.1.0",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A temporary fix so that lint does not error:

❯ yarn lint
yarn run v1.22.19
$ eslint . --cache
There was a problem loading formatter: /ember-codemod-pod-to-octane/node_modules/eslint/lib/cli-engine/formatters/stylish
Error: require() of ES Module /ember-codemod-pod-to-octane/node_modules/strip-ansi/index.js from /ember-codemod-pod-to-octane/node_modules/eslint/lib/cli-engine/formatters/stylish.js not supported.
Instead change the require of index.js in /ember-codemod-pod-to-octane/node_modules/eslint/lib/cli-engine/formatters/stylish.js to a dynamic import() which is available in all CommonJS modules.

@ijlee2 ijlee2 merged commit d8740f9 into main May 3, 2023
@ijlee2 ijlee2 deleted the downstream-changes branch May 3, 2023 07:21
@ijlee2 ijlee2 mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance: code Issue asks for new feature or refactor enhance: dependency Issue asks for a new or updated dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant