Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated to pnpm #24

Merged
merged 2 commits into from
May 17, 2023
Merged

Migrated to pnpm #24

merged 2 commits into from
May 17, 2023

Conversation

ijlee2
Copy link
Owner

@ijlee2 ijlee2 commented May 17, 2023

Background

In #23, I had to pin glob to v10.1.0 as I couldn't run the lint script.

Even now, after updating glob to the latest version (v10.2.4), I'm seeing a couple of issues with the install command and the lint script.

❯ yarn-deduplicate &&  yarn
yarn install v1.22.19
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
warning Pattern ["strip-ansi@^6.0.1"] is trying to unpack in the same destination as pattern ["strip-ansi-cjs@npm:strip-ansi@^6.0.1"]. This could result in non-deterministic behavior, skipping.
warning Pattern ["string-width@^4.1.0"] is trying to unpack in the same destination as pattern ["string-width-cjs@npm:string-width@^4.2.0"]. This could result in non-deterministic behavior, skipping.
warning Pattern ["strip-ansi@^6.0.0"] is trying to unpack in the same destination as pattern ["strip-ansi-cjs@npm:strip-ansi@^6.0.1"]. This could result in non-deterministic behavior, skipping.
warning Pattern ["string-width@^4.2.3"] is trying to unpack in the same destination as pattern ["string-width-cjs@npm:string-width@^4.2.0"]. This could result in non-deterministic behavior, skipping.
warning Pattern ["string-width@^4.2.0"] is trying to unpack in the same destination as pattern ["string-width-cjs@npm:string-width@^4.2.0"]. This could result in non-deterministic behavior, skipping.
warning Pattern ["wrap-ansi@^7.0.0"] is trying to unpack in the same destination as pattern ["wrap-ansi-cjs@npm:wrap-ansi@^7.0.0"]. This could result in non-deterministic behavior, skipping.
[4/5] 🔗  Linking dependencies...
[5/5] 🔨  Building fresh packages...
success Saved lockfile.
❯ yarn lint
yarn run v1.22.19
$ eslint . --cache
There was a problem loading formatter: /node_modules/eslint/lib/cli-engine/formatters/stylish
Error: require() of ES Module /node_modules/strip-ansi/index.js from /node_modules/eslint/lib/cli-engine/formatters/stylish.js not supported.
Instead change the require of index.js in /node_modules/eslint/lib/cli-engine/formatters/stylish.js to a dynamic import() which is available in all CommonJS modules.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

By using pnpm instead, I was able to run lint script again.

References

@ijlee2 ijlee2 added the enhance: dependency Issue asks for a new or updated dependency label May 17, 2023
@ijlee2 ijlee2 changed the title Migrated to pnpm for package manager Migrated to pnpm May 17, 2023
@ijlee2 ijlee2 marked this pull request as ready for review May 17, 2023 11:02
@ijlee2 ijlee2 merged commit c2ff833 into main May 17, 2023
@ijlee2 ijlee2 deleted the migrate-to-pnpm branch May 17, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance: dependency Issue asks for a new or updated dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant