Skip to content

Commit

Permalink
Pin Android NDK version to 21.4.7075529
Browse files Browse the repository at this point in the history
GitHub Actions seems to experience some issues with detecting the right
Android NDK to use. There all sorts of hacks with "side-by-side"
installation and "ndk-bundle" which you can read about elsewhere.

Resolve this predicament by pinning the NDK version we are using for
building our native code, both BoringSSL and Themis JNI stuff.

This means developers will have to install this specific version of NDK
instead of using whatever they are using. But that's not a particular
issue. NDK does not affect compatibility of apps either, unless Google
really screws up and breaks something there. Not in our case though
since we're not really using anything Android-specific in our code.

[debug] run on CI

[debug] disable stuff

Revert "Pin Android NDK version to 21.4.7075529"

This reverts commit 6767e61.

ANDROID_NDK_HOME

ANDROID_NDK_HOME

no

3.6.4

Revert "Revert "Pin Android NDK version to 21.4.7075529""

This reverts commit ae48ecd.

what if?

oh fuck you

Revert "3.6.4"

This reverts commit d369d2e.

Revert "no"

This reverts commit 9d47741.

Revert "ANDROID_NDK_HOME"

This reverts commit 36857d6.

Revert "ANDROID_NDK_HOME"

This reverts commit f9b7ecb.

Revert "Revert "Revert "Pin Android NDK version to 21.4.7075529"""

This reverts commit 3122e24.

asdasdas

asdsd

asdas

chec it out

asd

do eet

try to unfuck

and build again

oh fuck you too, actions

comments

Pin to macos-10.15 because fuck surpriises

do list first

try to make it faster

what if I just remove these instead

them just do this

and disable this for a moment

yep, seems to be working

rename
  • Loading branch information
ilammy committed May 21, 2021
1 parent 2bf951c commit 230f8a5
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion .github/workflows/test-java.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ on:
- master
- stable
- release/*
- pin-android-ndk
schedule:
- cron: '0 6 * * *' # every day at 6:00 UTC

Expand All @@ -30,6 +31,7 @@ jobs:
unit-tests:
name: Unit tests
runs-on: ${{ matrix.os }}
if: false
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
Expand Down Expand Up @@ -63,8 +65,15 @@ jobs:
android-tests:
name: Android emulator
runs-on: macos-latest
runs-on: macos-10.15
steps:
# This particular version of CMake confuses Gradle by not being semver.
# We're fine with 3.10.2 which is also installed. Keep an eye on the
# virtual environments though:
# https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md#android
- name: Nuke CMake 3.18.1-g262b901
run: |
~/Library/Android/sdk/tools/bin/sdkmanager --uninstall 'cmake;3.18.1'
- name: Check out code
uses: actions/checkout@v2
with:
Expand All @@ -89,6 +98,7 @@ jobs:
android-example:
name: Example – AndroidThemis
runs-on: ubuntu-latest
if: false
steps:
- name: Check out code
uses: actions/checkout@v2
Expand All @@ -102,6 +112,7 @@ jobs:
java-example:
name: Example project – JavaThemis
runs-on: ubuntu-latest
if: false
steps:
- name: Install system dependencies
run: |
Expand Down

0 comments on commit 230f8a5

Please sign in to comment.