Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 kind dev environment #38

Merged
merged 62 commits into from
Apr 25, 2022
Merged

3 kind dev environment #38

merged 62 commits into from
Apr 25, 2022

Conversation

ilan-pinto
Copy link
Owner

new features - one-click for building a local env

ilan-pinto and others added 30 commits April 11, 2022 12:51
Signed-off-by: Ilan Pinto <ilpinto@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
…allow aggregation of results

Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
…oject command

Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
@TomerFi
Copy link
Collaborator

TomerFi commented Apr 19, 2022

@ilan-pinto
We have another issue we need to address.

Note the failing CI workflows,
for both the macos, and ubuntu, the failure's cause is:
ERROR: Coverage for lines (51.28%) does not meet global threshold (90%)

which makes sense considering we still need to add tests to this PR.

but the windows workflow, the tests actually fail.
we fail while testing the creation of new projects:
we get TypeError: Cannot read properties of undefined (reading 'then') while trying to work with the promise:
https://github.com/ilan-pinto/ocm-vscode-extension/runs/6073997687?check_suite_focus=true#step:6:38

ilan-pinto and others added 6 commits April 19, 2022 11:18
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
TomerFi and others added 7 commits April 20, 2022 15:17
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Refactor the command for creating a local development environment
@TomerFi
Copy link
Collaborator

TomerFi commented Apr 21, 2022

LGTM

For this PR to be merged, IMO we need:

1- address the two remaining review comments.

2- add unit test for the build utility functions.
this is required for increasing the code coverage percentage which is the cause of the CI failures.

3- examine and solve what's wrong with the Windows CI workflow.
it fails before coverage verification, might be an OS-specific issue.

4- we need more integration tests, we only cover the createNewProject command.
at the very least we need to also cover the buildLocalEnvironment command.

@ilan-pinto
Maybe it will be best to switch this PR to draft.
so it won't get merged by mistake before we're done.

Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
@TomerFi TomerFi merged commit 907d575 into main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] start up local kind dev environment
3 participants