Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong bad variant underline in error case. #97

Closed
GilShoshan94 opened this issue Jan 15, 2023 · 1 comment · Fixed by #98
Closed

Wrong bad variant underline in error case. #97

GilShoshan94 opened this issue Jan 15, 2023 · 1 comment · Fixed by #98

Comments

@GilShoshan94
Copy link
Contributor

With PR #96, and also in #89 there are case, if the alternative values are not written in order, that in erro case, the wrong value is underline as such:
(1 should be underlined)
image

(0 should be underlined)
image

I am working on the PR to fix this minor issue.
GilShoshan94 added a commit to GilShoshan94/num_enum that referenced this issue Jan 15, 2023
@GilShoshan94
fix illicitonion#97
d14156b
@GilShoshan94 GilShoshan94 mentioned this issue Jan 15, 2023
Merged
@GilShoshan94
Copy link
Contributor Author

I submited PR #98

Once merged I will close this.

illicitonion pushed a commit that referenced this issue Jan 16, 2023
@GilShoshan94
Underline the correct alternative variant in case of error. (#98)
483e933 
Fix #97.

Small PR to underline the correct alternative variant when they are not written in order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Underline the correct alternative variant in case of error. GilShoshan94/num_enum
1 participant
@GilShoshan94