Underline the correct alternative variant in case of error. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GilShoshan94
changed the title
|
This change looks good to me, thanks! Could I bother you to add a test for this? If you add a simple example .rs file to https://github.com/illicitonion/num_enum/tree/main/num_enum/tests/try_build/compile_fail (like https://github.com/illicitonion/num_enum/blob/main/num_enum/tests/try_build/compile_fail/alternative_exprs.rs) and run the tests, it should output the required .stderr file which you can move into the same directory. |
|
Done, I added 2 tests for that. |
|
@illicitonion, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #97.
Small PR to underline the correct alternative variant when they are not written in order.
Before:
After: