Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of getType() API #654

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Addition of getType() API #654

merged 5 commits into from
Aug 29, 2024

Conversation

tpietzsch
Copy link
Member

Changes that will be required after imglib/imglib2#312 is merged and released

Depends on upgrade of imagej-common.

* Add missing getType() implementations
* Follow API changes from imglib/imglib2-roi#71

Signed-off-by: Curtis Rueden <ctrueden@wisc.edu>
@ctrueden ctrueden force-pushed the feature-rai-getType branch from 813b6a9 to ccb600e Compare June 11, 2024 15:47
@ctrueden
Copy link
Member

Remaining compilation error:

[ERROR] ...imagej-ops/src/main/java/net/imagej/ops/labeling/MergeLabeling.java:[95,81] reference to sample is ambiguous
  both method <T>sample(net.imglib2.IterableInterval<java.lang.Void>,net.imglib2.RandomAccessible<T>) in net.imglib2.roi.Regions and method <T>sample(net.imglib2.roi.IterableRegion<?>,net.imglib2.RandomAccessible<T>) in net.imglib2.roi.Regions match

I will fix it after I return from vacation, if no one else has done so already!

@tpietzsch
Copy link
Member Author

I fixed the remaining compile error.

This is ready to go as soon as imagej/imagej-common#112 is merged and released.

imagej-common is the only SNAPSHOT dependency left

@ctrueden ctrueden marked this pull request as ready for review August 28, 2024 22:26
@ctrueden ctrueden merged commit 1ffa597 into master Aug 29, 2024
1 check passed
@ctrueden ctrueden deleted the feature-rai-getType branch August 29, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants