Refactor boundary condition #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isteinbrecher
commented
Apr 16, 2025
isteinbrecher
force-pushed
the
refactor-boundary-condition
branch
from
aeef9cb to
a71d69d
Compare
davidrudlstorfer
approved these changes
Apr 17, 2025
10 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #325 #324 (this PR already includes the changes made in those PRs).
This PR refactors the boundary condition framework. Previously, we had both a general boundary condition base class and a separate boundary condition in the 4C folder. However, the 4C implementation included general-purpose functionality that wasn’t truly specific to 4C.
This PR proposes using the general boundary condition class for 4C meshes as well, which seems reasonable since all necessary data can be stored in the
BaseMeshItem.dataattribute.Once this is merged, this should serve as a starting point for refactoring the
Coupling.Other points:
bc_dicttodata, this should not break any interfaces, but internally is more consistent and general in my opinion.BoundaryCondtionfrom an existing yaml file functionality was moved toinput_file.pywhich makes much more sense in my opinion.