Move input file & testing to fourcipp #330

davidrudlstorfer · 2025-04-28T22:00:48Z

This evening I finally found some time to really tackle this larger move (following the initial discussion and plan in #321) to fourcipp

The present changes are a very rough WIP and are not ready yet (I hope that this is clear :D)

The first draft now proposes the completely overhauled FouCInputFile structure which is based on fourcipp.

Some points:

The basic functionality works as expected and the code is simplified by a lot
I now provided a general utility function which converts a MeshPy mesh into a dictionary (without depending on 4C stuff) => we can reuse this in testing to compare two Meshes

The missing points

Finalize coupling, boundary conditions, geometry sets, Nurbs to mesh->dict conversion
Finalize initial conversion from an input file to a mesh for boundary conditions and geometry sets
remove last dump_to_list remnants (except for Nurbs -> I have no overview on how to approach this the best way)
remove last _if_fourcipp_is_available occurences (except for Nurbs -> I have no overview on how to approach this the best way)
use fourcipp dict comparison in testing
update tests

davidrudlstorfer · 2025-04-29T14:30:55Z

@isteinbrecher today I also made a lot of progress on this PR and it's already looking good

I am now able to execute the following script, i.e., create a mesh + input file from scratch with (almost) everything (except the nurbs patches), read an existing input file as a pure input file and not convert it to a mesh, convert an existing input file into a MeshPy mesh and write it out again.

I think the overall changes are coming to a (more or less) final form. There are still a lot of open ToDo's. But I think going forward it would make sense if you could quickly look over the changes or if we discuss some of it in the upcoming days/weeks.

I am curious about your opinion.

Script

from meshpy.four_c.input_file import FourCInputFile
from meshpy.core.mesh import Mesh
from meshpy.four_c.material import MaterialReissner, MaterialEulerBernoulli
from meshpy.mesh_creation_functions.beam_basic_geometry import (
    create_beam_mesh_line,
    create_beam_mesh_helix,
)
from meshpy.four_c.function import Function
from meshpy.four_c.element_beam import Beam3rHerm2Line3, Beam3eb
from meshpy.core.boundary_condition import BoundaryCondition
from meshpy.core.geometry_set import GeometrySet
from meshpy.utils.nodes import is_node_on_plane
from meshpy.core.conf import mpy
import numpy as np

if __name__ == "__main__":

    mesh = Mesh()

    mat = MaterialReissner(youngs_modulus=1e5, radius=0.5, shear_correction=1.0)

    create_beam_mesh_line(
        mesh, Beam3rHerm2Line3, mat, [0.0, 0.0, 0.0], [1.0, 0.0, 0.0]
    )

    # Add boundary condition to bottom node
    mesh.add(
        BoundaryCondition(
            GeometrySet(
                mesh.get_nodes_by_function(
                    is_node_on_plane,
                    normal=[0, 0, 1],
                    origin_distance=0.0,
                    tol=0.1,
                )
            ),
            {
                "NUMDOF": 9,
                "ONOFF": [1, 1, 1, 1, 1, 1, 0, 0, 0],
                "VAL": [0, 0, 0, 0, 0, 0, 0, 0, 0],
                "FUNCT": [0, 0, 0, 0, 0, 0, 0, 0, 0],
            },
            bc_type=mpy.bc.dirichlet,
        )
    )

    # Create helix.
    create_beam_mesh_helix(
        mesh,
        Beam3eb,
        MaterialEulerBernoulli(youngs_modulus=1e5, radius=0.5),
        [1.0, 1.0, 1.0],
        [-1.0, -1.0, -1.0],
        [1.0, 1.0, 1.0],
        helix_angle=np.pi / 6,
        height_helix=80.0,
        n_el=4,
        warning_straight_line=False,
    )

    mesh.add(
        Function(
            [
                {
                    "COMPONENT": 0,
                    "SYMBOLIC_FUNCTION_OF_SPACE_TIME": "t",
                },
            ]
        )
    )

    input_file = FourCInputFile()

    input_file.add(mesh)

    input_file["PROBLEM TYPE"] = {"PROBLEMTYPE": "Structure"}

    input_file.dump(
        "test.4C.yaml",
        sort_sections=False,
        validate_input_file=True,
        add_header_information=True,
        add_header_default=True,
        add_footer_application_script=True,
    )

    # also test second approach to load input file (not as mesh)
    input_file2 = FourCInputFile().from_4C_yaml(input_file_path="test.4C.yaml", convert_input_to_mesh=False)

    # also test third approach to load input file (and convert to mesh)
    input_file3, mesh2 = FourCInputFile().from_4C_yaml(input_file_path="tests/reference-files/4C_input_solid_cuboid.4C.yaml", convert_input_to_mesh=True)

    input_file3.add(mesh2)

    input_file3.dump("test2.4C.yaml", validate_input_file=False)

isteinbrecher

Thanks for the work @davidrudlstorfer (and please don't get discouraged by my many comments, there are just a lot of changes).

One thing I am not exactly sure, I thought we agreed to not have any dump methods in the mesh items (#326 (comment)) - this would help to solve all the parts I marked that are currently in core but should move somewhere to four_c.

Regarding your example script, I like the approach with from_4C_yaml (will take some time getting used to, but I think it makes sense). I am thinking if it makes sense to not have this as a class method but as a free function load_4C_yaml, and always return two variables (otherwise we will have a lot of additional ifs in testing).

    # also test second approach to load input file (not as mesh)
    # input_file2 = FourCInputFile().from_4C_yaml(input_file_path="test.4C.yaml", convert_input_to_mesh=False)
    input_file2, _ = load_4C_yaml("test.4C.yaml", convert_input_to_mesh=False)

    # also test third approach to load input file (and convert to mesh)
    # input_file3, mesh2 = FourCInputFile().from_4C_yaml(input_file_path="tests/reference-files/4C_input_solid_cuboid.4C.yaml", convert_input_to_mesh=True)
    input_file3, mesh2 = load_4C_yaml("tests/reference-files/4C_input_solid_cuboid.4C.yaml", convert_input_to_mesh=False)

I think it makes sense to sit together and talk about some of the points. I will let you know what dates are good for me.

isteinbrecher · 2025-04-29T14:45:13Z

src/meshpy/core/conf.py

@@ -156,9 +156,6 @@ def set_default_values(self):
        # match.
        self.allow_beam_rotation = True

-        # Import meshes as pure dict or import the geometry.
-        self.import_mesh_full = False


🎉 nice to see this monster go!

isteinbrecher · 2025-04-29T14:50:03Z

src/meshpy/core/element_volume.py

@@ -41,16 +41,15 @@ def __init__(self, nodes=None, string_pre_nodes="", string_post_nodes="", **kwar
        self.string_pre_nodes = string_pre_nodes
        self.string_post_nodes = string_post_nodes

-    def dump_to_list(self):
-        """Return a list with the items representing this object (usually a
+    # ! TODO fix this export with a dict


Is there a reason we can not do this straight away? Maybe if we apply my previous comment this would resolve itself? Or am I misunderstanding something here?

isteinbrecher · 2025-04-29T14:56:24Z

src/meshpy/core/geometry_set.py

+            {
+                "type": "NODE",
+                "node_id": node.i_global,
+                "d_type": self.geometry_set_names[self.geometry_type],


Pre evalutare

isteinbrecher · 2025-04-29T14:57:38Z

src/meshpy/four_c/dbc_monitor.py

@@ -148,7 +148,7 @@ def read_dbc_monitor_file(file_path):


 def add_point_neuman_condition_to_input_file(
-    input_file: _InputFile,
+    input_file: _FourCInputFile,


I think this has to be a Mesh.

isteinbrecher · 2025-04-29T14:58:41Z

src/meshpy/core/boundary_condition.py

@@ -124,6 +124,15 @@ def check(self):
                    "specified on how to handle them!"
                )

+    def dump_data(self) -> _Dict:


I would not put this here. This is 4C specific and should not be in core in my opinion.

isteinbrecher · 2025-04-29T16:14:30Z

src/meshpy/utils/convert_mesh_to_dict.py

+    return dict
+
+
+def add_items_to_dict(dict, section_name, items):


Side node, but we could mark functions like this as private _add_items_to_dict.

isteinbrecher · 2025-04-29T16:17:18Z

src/meshpy/utils/convert_mesh_to_dict.py

+def convert_mesh_to_dict(
+    mesh: _Mesh,
+    *,
+    global_start_indices: dict = {_Node: 0, _Element: 0, _Material: 0, _Function: 0}


I think a better approach would be to provide an empty dict here and do all lookups like

global_start_indices.get(xxx, default=0)

Then, for example if I only want to provide a starting index for elements, because everything else starts with 0 in my solver, I can simply pass a dict with a single entry for the element starting index and the others indices will automatically be 0.

isteinbrecher · 2025-04-29T16:30:16Z

src/meshpy/four_c/input_file.py

+            if item_type == _Node:
+                indices[_Node] = len(self.sections.get("NODE COORDS", []))
+
+            # elements


I think think the comments here are not needed (also for nodes, materials, ...)

isteinbrecher · 2025-04-29T16:30:54Z

src/meshpy/four_c/input_file.py

-                xml_file.write(self.nox_xml)
+            # materials
+            elif item_type == _Material:
+                indices[_Material] = max(


Very nice how simple this has become.

isteinbrecher · 2025-04-29T16:55:58Z

src/meshpy/four_c/input_file.py

-            ):
-                self.add_section(args[0], **kwargs)
-                return
+        return input_file, mesh


I am not sure if I missed this, but do we ever delete the mesh related information from input_file?

davidrudlstorfer self-assigned this Apr 28, 2025

WIP

ffa452e

davidrudlstorfer force-pushed the move_to_fourcipp branch from b05b409 to ffa452e Compare April 29, 2025 14:26

isteinbrecher reviewed Apr 29, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move input file & testing to fourcipp #330

Move input file & testing to fourcipp #330

davidrudlstorfer commented Apr 28, 2025 •

edited

Loading

davidrudlstorfer commented Apr 29, 2025

isteinbrecher left a comment

isteinbrecher Apr 29, 2025

isteinbrecher Apr 29, 2025

isteinbrecher Apr 29, 2025

isteinbrecher Apr 29, 2025

isteinbrecher Apr 29, 2025

isteinbrecher Apr 29, 2025

isteinbrecher Apr 29, 2025

isteinbrecher Apr 29, 2025

isteinbrecher Apr 29, 2025

isteinbrecher Apr 29, 2025

		return dict


		def add_items_to_dict(dict, section_name, items):

Move input file & testing to fourcipp #330

Are you sure you want to change the base?

Move input file & testing to fourcipp #330

Conversation

davidrudlstorfer commented Apr 28, 2025 • edited Loading

davidrudlstorfer commented Apr 29, 2025

isteinbrecher left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidrudlstorfer commented Apr 28, 2025 •

edited

Loading